Comments (8)
I'm sorry to hear this is causing issues. Will try to have a look at this asap!
from docat.
PR is ready, would be nice if someone could have a look at it :)
from docat.
Ahhh now I get it. Sorry, I made a pretty obvious mistake!
The order of the routes got just wrong, after I made the version
param optional.
{ path: '/', component: Home },
{ path: '/:project/:version?/:location(.*)?', component: Docs },
{ path: '/help', component: Help },
{ path: '/upload', component: Upload },
{ path: '/claim', component: Claim },
{ path: '/delete', component: Delete },
Sorry, should have realized this. Will create a pr with a fix for this.
from docat.
@lukasweber apparently this was introduced by your change: #132
Do you have any idea what's going on?
from docat.
@lukasweber did you had a chance to look at it?
from docat.
Hi @galaplexus,
I just tried to reproduce the issue with your description, but didn't run into it yet. I did the following:
-
Clone the latest
main
-
Build the docker image with
docker build -t docat .
=> [stage-2 2/11] RUN apk update && apk add nginx dumb-init && rm -rf /var/cache/apk/* 2.6s => [backend 2/6] RUN apk update && apk add gcc musl-dev python3-dev libffi-dev openssl-dev cargo 16.7s => [stage-2 3/11] RUN mkdir -p /etc/nginx/locations.d 0.2s => [stage-2 4/11] RUN mkdir -p /var/docat/doc 0.2s => [stage-2 5/11] RUN chown -R nginx /var/docat /etc/nginx/locations.d 0.2s => [stage-2 6/11] RUN mkdir -p /var/www/html 0.2s => [backend 3/6] RUN pip install poetry==1.1.13 12.5s => [build-deps 2/7] COPY web ./ 0.3s => [build-deps 3/7] COPY doc/getting-started.md ./src/assets/ 0.0s => [build-deps 4/7] RUN yarn install --frozen-lockfile 75.6s => [backend 4/6] COPY /docat/pyproject.toml /docat/poetry.lock /app/ 0.0s => [backend 5/6] WORKDIR /app/docat 0.0s => [backend 6/6] RUN poetry install --no-root --no-ansi --no-dev 13.6s => [build-deps 5/7] RUN yarn lint 1.0s => [build-deps 6/7] RUN yarn run test:unit 2.0s => [build-deps 7/7] RUN yarn build 10.8s => [stage-2 7/11] COPY --from=build-deps /dist /var/www/html 0.0s => [stage-2 8/11] COPY docat /app/docat 0.0s => [stage-2 9/11] WORKDIR /app/docat 0.0s => [stage-2 10/11] RUN cp docat/nginx/default /etc/nginx/http.d/default.conf 0.1s => [stage-2 11/11] COPY --from=backend /app /app/docat 0.1s => exporting to image 0.1s => => exporting layers 0.1s => => writing image sha256:ee567972a141e13ab4cff0d9a745803ebde396a68950b4cb5ba3d70d57ca212b 0.0s => => naming to docker.io/library/docat 0.0s
-
Run the image using
docker run -d --rm --publish 8000:80 docat
-
Uploading a doc
curl -X POST -F "[email protected]" http://localhost:8000/api/awesome-project/1.0.0
After clicking around on the UI I didn't run into the issue described by you. I only got a TypeError: this.$el.validity is undefined
error when switching the versions, but I'm not sure if this is really related to my change.
Could you provide me with the Repro Steps?
However by looking at my change, I think it could be worth splitting the route into two routes referring the same component, so we can get rid of having two optional params in one. Let me know what you think :)
from docat.
Can you try running the latest master build something like this ->
sudo docker run --rm --publish 8000:80 ghcr.io/docat-org/docat:1bceb352479c68719c6330ab46f3c54342b85965
And then you select in the bottom right the upload button (or got to http://localhost:8000/#/upload).
from docat.
thanks 🎉
from docat.
Related Issues (20)
- Add support for https://lunrjs.com/ search index HOT 3
- Improvement: Issue no index.html warning in UI as well
- Question: Uploading files seems to override the index.html HOT 3
- Allow setting path to entry point HOT 1
- Minor UI Issues
- Migrate to Vite
- Fix history not working correctly on docs page
- Pipeline running twice for PRs
- Fix Iframes not blocked
- CI Token management HOT 4
- Optimize Dockerfile
- Add 404 page to go back to the current `PROJECT`/`VERSION` home
- Query available versions of a project HOT 2
- Adding a tag doesn't seem to require API key authorization HOT 4
- Docker image should not contain tests
- how can I stay in tag (like `latest`) in url without redirect to version in url HOT 7
- Improvement: Don't show copy button in insecure contexts.
- Photoshop-1998/:;()&@
- Config file `config.json` not working HOT 1
- Read-only users HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docat.