Switch to Guzzle4?

[docker-php]

Switch to Guzzle4?

[joelwurtz]

Just see the post, indeed, seems far better than the v3, it will allow docker-php to focus more on docker API and not on request / response stuff.

[joelwurtz]

We need to have our own adapter, as the StreamAdapter of Guzzle 4 only allow to get the response as stream but does not send the request with a stream, it will cause a regression for the memory problem with big context.

[cordoval]

👍

[ubermuda]

@joelwurtz thanks for having a look! Do you think it would be possible to contribute to the existing stream adapter instead of writing a new one completely from scratch?

[joelwurtz]

Yes definitely, i think we have to rewrite the request part in the StreamAdapter and add an option to send the request as a stream.

Actually guzzle send the request by creating a stream_context and populate the header and content option. Then they open the url with "fopen" and passing the context to it : https://github.com/guzzle/guzzle/blob/master/src/Adapter/StreamAdapter.php#L342

We have to wait for this PR also : guzzle/streams#4 as we have a stream from a proc_open pipe and there is no uri so we got an error with the build command.

[joelwurtz]

Also for the moment i only tested with http url (so tcp transport), and i'm not sure it will work with file socket transport, we may also need to write a PR to specify the transport entrypoint for the StreamAdapter to work with unix:///var/run/docker.sock

[joelwurtz]

Solve with #34