Importing assertionInjector disables the whole test module

[dockyard]

Importing assertionInjector disables the whole test module

[bcardarella]

@lolmaus what version of ember-cli are you using? This is clearly bad

[lolmaus]

Ember CLI 1.13.8
Ember 2.1.0-beta.2
ember-qunit 0.4.10
qunit 1.19.0
ember-cli-qunit 1.0.1

[bcardarella]

Thank you, I'll try updating our test suite for that set. Will report back soon

[lolmaus]

🙇

[rwjblue]

It might be an invalid import which would result in an error when the test modules are loaded, but with your ember-cli-qunit version this error should be notated with a failing test (this is done here).

[lolmaus]

@rwjblue You're right:

TestLoader Failures: exam-sim-ember/tests/unit/models/exam-session-test: could not be loaded
Error: Could not find module exam-sim-ember/tests/unit/assertions

I'm doing import { assertionInjector } from '../assertions';.

This doesn't look right, but neither does this.

[rwjblue]

Seems correct to me.

You added one extra level since your test is at tests/unit/models/exam-session-test.js, you would need to import { assertionInjector } from '../../assertions';.

[rwjblue]

You could also use import { assertionInjector } from '<your app name>/tests/assertions'; if you didn't want to deal with the annoyance of the tracking down the right number of ../ to add when importing.

[rwjblue]

As an aside, I'm pretty happy that ember-cli-qunit is giving you exactly what you need to fix this via a failing test. For quite a while errors thrown while evaluating the module (like invalid imports) caused the whole test module to be completely ignored with no indication of any failure.

[lolmaus]

It didn't help me because there was no assertions file at that path, so it was pretty magical to me.