Comments (18)
I recommended https://github.com/ef4/memory-scroll
from ember-router-scroll.
I am asking myself the same question. Seems it is in ember, but need to be enabled somehow. How?
from ember-router-scroll.
from ember-router-scroll.
Yes, this addon is still needed. The RFC to Ember simply made this addons job a tad bit easier (and allowed it to rely on only public APIs). Specifically, I believe that step 3 in the usage instructions on the README is no longer needed with Ember 2.13.
@bcardarella and/or @briangonzalez can y'all confirm?
from ember-router-scroll.
The Location can be deprecated but the Service is still necesarry
from ember-router-scroll.
and the router mixin is still necessary
from ember-router-scroll.
Using version 0.2.0 and ember 2.13.3, I can't get this working at all yet.
I ember install'ed, Router mixin'ed, and (progressively, to test) added the two environment.js lines. To no avail, not sure if I'm just missing something--will try to post example repo later if I can't sort it out.
from ember-router-scroll.
@rwjblue I believe 2.14 is when the feature flag drops. It is still there for 2.13: https://github.com/emberjs/ember.js/blob/v2.13.3/packages/ember-routing/lib/location/history_location.js#L19
from ember-router-scroll.
That makes sense, I got thrown by the "until released in 2.13" bit. Referring to ember-source
, I can't use the feature flags, but when I bump to "ember-source": "2.14.0-beta.3"
, I'm still not getting any results. Do the story/instructions change in 2.14?
from ember-router-scroll.
The only difference that should be necessary in 2.14 will be not having to change your location type in config/environment.js
from ember-router-scroll.
Gotcha. Still nada when I go back to auto
, but I'm gonna assume I have some environmental issue going on and try this on a new app before I continue to pester here. Thanks for the heads up(s) 👍
from ember-router-scroll.
@bcardarella - I didn't strip the conditional in the source until later, but the feature is enabled in 2.13.
from ember-router-scroll.
Re: @maxwerr's issue. I just SH'd with him and there appears to be something else at play. The window.scrollY
value never changes. I suspect the scrolling is within a container div with an overflow allowed and not changing the actual window height. This won't work with ember-router-scroll
from ember-router-scroll.
If I understand correctly, this repo should be fixed up with?
- Keep service and mixin
- Remove location
- Major version bump
- Fix tests
from ember-router-scroll.
@briangonzalez I would recommend a deprecation in the location for the time being that detects the Ember version. >= 2.13 display deprecation that recommends keeping the location as auto
or history
. This way upgrades won't break.
from ember-router-scroll.
Post major version bump location can be dropped
from ember-router-scroll.
Thoughts on publishing them in tandem? This addon is currently at 0.2.0
0.2.0
->0.3.0
deprecation warning for location0.2.0
->1.0.0
location removed
from ember-router-scroll.
Seems good to me!
from ember-router-scroll.
Related Issues (20)
- 1.1.0 breaks preserveScrollPosition HOT 1
- Release new version with fixed Ember 3.9 deprecations HOT 7
- deprecation warning: Setting 'locationType' to 'router-scroll' HOT 2
- deprecation warning: Setting a computed property as volatile has been deprecated HOT 2
- 1.3.0, 1.3.1 releases are incompatible with Ember Fastboot HOT 5
- preserveScrollPosition doesn't work HOT 4
- Provide non Mixin approach HOT 1
- Provide utils if don't use EmberRouter HOT 2
- Emit event when scrollTo occurs
- Could not find module `ember-test-waiters` imported from `ember-app-scheduler/scheduler` HOT 3
- Don't scroll the page during the tests
- Use `RouterService` instead of extending Ember `Router`
- Restore scroll position after transition, via history.back(), resolves HOT 2
- Don't scroll on initial load HOT 3
- Deprecation warning still present in 4.0 HOT 5
- Upgrade to version 4.x leads to test errors HOT 7
- README Correction - export DEFAULT class... HOT 2
- Allow configuration of MAX_ATTEMPTS for tryScrollRecursively
- Prevents apps from stubbing router service in unit tests HOT 1
- Allow nested controllers to override preserveScrollPosition
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-router-scroll.