DBAL-50: PgSQL driver does not create indexes on foreign key columns

[doctrinebot]

DBAL-50: PgSQL driver does not create indexes on foreign key columns

[doctrinebot]

• is referenced by DBAL-1063: Exceptions from SchemaTool when running with DBAL 2.5.0
• is referenced by DDC-3478: [GH-1239] Fix index duplication for unique association join columns

[doctrinebot]

Comment created by petr_motejlek:

I'd just like to add that there's an even worse problem with this -- the indices are not created even for tables that Doctrine creates automatically -- for example the joining tables...

[doctrinebot]

Comment created by @beberlei:

i'll look into it.

[doctrinebot]

Comment created by @beberlei:

Fixed in master, leading to several follow up bugs that all had to be fixed:

1. generate identifier allowed first char to be a number
2. postgresql composite foreign key detection left a space in the second (and more) column names
3. Index column names were not sanitized to lower-case, leading to comparison bugs.

There has been a major refactoring now such that, for each foreign key there is always an explicit index being created. On SQLite, Postgres and Oracle this can lead to quite some additional indexes being created now using SchemaTool --update. MySQL already did this implicitly.

There are now heuristics that detect duplicate indexes (based on columns indexed) and override rules (adding primary on columns foo, bar will delete index on columns foo bar).

[doctrinebot]

Comment created by @beberlei:

Note, this commit will not get into Doctrine ORM master unless you update the git-submodule explicitly:

cd lib/vendor/doctrine-dbal
git checkout master

For RC-1 this will be visible to the ORM trunk/master also.

[doctrinebot]

Issue was closed with resolution "Fixed"

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.