Giter Site home page Giter Site logo

Comments (2)

derrabus avatar derrabus commented on May 20, 2024

There are cases when it's required to extact$wrappedDriver

And which cases would that be? The middleware stacks are not designed to be unwrapped and that's kind of on purpose.

but AbstractDriverMiddleware does not have such public api.

Please be aware that AbstractDriverMiddleware is by no means a contract. It's a utility class. The contract of a driver middleware class is the Driver interface. A class that only implements that interface and not the abstract class is still a valid driver middleware class.

So, even if we did add such a method to AbstractDriverMiddleware, it would not guarantee that you could actually unwrap the whole driver stack.

I don't know what problem you are trying to solve, but I would kindly ask you to find a different way.

from dbal.

oleg-andreyev avatar oleg-andreyev commented on May 20, 2024

Case is mentioned here DamienHarper/auditor#184 and https://github.com/DamienHarper/auditor/blob/8edca5bedfda2f838003471321c60c45d941ba03/src/Provider/Doctrine/Auditing/Event/DoctrineSubscriber.php#L37-L42

this could be a wrong implementation from auditor lib, but it's OCP, we decorate connection/driver to add extra functionality - so imo valid solution to check instance if needed, but because driver/connection could be wrapped by many other decorators logic could be broken, that's why need to rewind or unwrap.

from dbal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.