Comments (3)
I work in developer support at DocuSign, and as I recall our customers used to be confused by setting this up in demo, missing the step of setting the oauth host, and ending up with the oath request being sent to production. That is the why we raise an error now instead of setting a default value. I have posted a bug to cleanup the unexecuted code.
from docusign-esign-python-client.
This bug is filed as [DCM-7258] Unexecuted Code in python API client.
from docusign-esign-python-client.
There is an internal method that is still expecting this empty call to implicitly define the oauth server.
Silently defaulting to production is bad, but it can be fixed without discarding the convenience. The underlying problem with the original code was that the else
branch unconditionally used the production server. It could require the base path to match production to make it safe and convenient. If the base path is not defined, it should error. If the base path doesn't have a corresponding auth server, it should error also.
A slightly related topic: The way oauth_host_name
is required across ApiClient
methods is inconsistent.
- These methods require it to be passed as an argument every call:
request_jwt_user_token
request_jwt_application_token
- This method requires it to be set before calling, doesn't accept an arg for it, and validates it is set:
get_user_info
- This method assumes it is set without validation, doesn't accept an arg for it, and will try to make a post request to the host name
None
if it wasn't set:generate_access_token
- This is the method that will error when trying to use the implicit logic that is now unreachable:
get_authorization_uri
The first 2 methods that require the positional arg can't be fixed without a major version bump (or 2 depending up your deprecation policies). I'm not sure what the maintainers' stance will be on set-then-call, optional-kwarg, or required-arg, but I would recommend settling on one and make sure all the methods use that pattern in the next (few?) major release(s?). generate_access_token
has a bug and should validate the auth server in a patch.
from docusign-esign-python-client.
Related Issues (20)
- How to assign SignHere Tabs in Bulk Send Envelope HOT 2
- Test issue by Larry
- Larry K test
- Larry K Test
- envelopesAPI get_document does not have option to return bytes HOT 2
- Dependencies : PyJWT version is too old HOT 7
- kwargs['_return_http_data_only'] = True in each function of ****_api.py HOT 1
- Way to Set Signing order to False by default? HOT 1
- Module 'Docusign_esign.models' has no attribute 'Date' HOT 16
- envelope_api update_recipients recipients The request body is missing or improperly formatted. Could not cast or convert from System.String to API_REST.Models.v2_1.recipients. HOT 1
- Incorrect exception type raised
- Bug report: getting JWT token now has PyJWT issues HOT 11
- Possibility about PyJWT dependency bump HOT 5
- Non-standard date output format difficult to parse
- Development and build dependencies are listed as install requirements of this project HOT 3
- Better Error Handling for Missing Variables HOT 1
- ApiException causes no attribute 'trace_token' exception when trying to print it HOT 1
- EventNotification: webhook doesn't get data in the json format HOT 1
- How to update an envelope and change it's status from 'sent' to 'voided' HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from docusign-esign-python-client.