Manage labels on nodes to allow having less static IPs than nodes

[doitintl]

Manage labels on nodes to allow having less static IPs than nodes

[WilliamDenniss]

In my testing you can still add more nodes, they just won't get static IPs. If you rely on all your nodes being whitelisted, then yes it won't work. +1 to label the nodes that receive the static IP. Being able to run mixed workloads on the same nodepool where only some require a static IP would be great!

I'd suggest adding a second label, which is the name of the IP itself. That way you could use nodeSelector to target a Pod to a specific IP which could serve other use-cases like exposing a service with HostPort.

[avivl]

@pdecat @WilliamDenniss
After assigning an IP address to a node kubeip will also create a label for that node kubip_assigned with the value of the IP address (. are replaced with _)

[avivl]

@pdecat @WilliamDenniss just to be on the safe side, I'm now checking if there is a node with the ip tag and clear that tag

[pdecat]

Great, so it's just a matter of adding/removing labels, isn't it?

[spark2ignite]

@avivl - would be better to replace the dots with dashes as per K8s notion specified at https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pods

[pdecat]

@avivl are the labels removed when a node fails and the IP was reassigned to another one?

[avivl]

@pdecat If the node will get a new IP then the value of the label will be overwritten

[pdecat]

What if there are less reserved IP addresses than nodes?

[avivl]

@pdecat nothing. If there are less IP address then nodes then nothing will happen to this nodes. Once an IP will be available it will be assigned to one e of the nodes

[pdecat]

It will still have a tag referencing an IP address that has been reassigned to another node, isn't it?

If so, pods can't rely on this label via nodeSelector or affinity constraints to be scheduled on those.

Note: perhaps that wasn't clear in my original description but that's what this issue is all about.

[WilliamDenniss]

@avivl are the labels removed when a node fails and the IP was reassigned to another one?

Ideally I think the kubeIP operator would validate that both labels are correct as part of the regular poll, and remove labels that are no longer correct. From a consistency standpoint this seems like the ideal behavior.

But I'm curious if this condition can actually happen today? I would think once assigned, it wouldn't be unassigned. Or are you suggesting that the user or some other process may re-assign it?

[pdecat]

Oh, I presumed kubeip would do it for failing or upgraded (cordon, drain, reboot) nodes but now that you mention it, I realize it watches only for new/removed nodes.

I guess as long as failing and upgraded nodes keep their reserved IP address, this is covered.

[pdecat]

Great, thanks!