Self-referencing foreign key constraint breaks auto-incrementing ids in memory mode

[mlucic]

Self-referencing foreign key constraint breaks auto-incrementing ids in memory mode

[max-hoffman]

I can repro, this one is a little trickier but basically the same thing. Before we were bleeding information between transactions, failing to reset editor data created an insert editor with a split brain. Now we're bleeding information between analysis and execution. When we resolve foreign keys the session initializes a tableEditor for the FK table. Because the FK table is the same as the insert table, we lose track of the difference when we initialize the execution insert editor. Same error root cause, the editor that lands id increments is not the editor with the insert data.

I do not understand why the FK table editor needs to share the same namespace as the insert table and will look into this. But the solution is either 1) make the session namespace differentiate these two states, 2) make sure the insert editor tracks the analysis editor, 3) make some structural change where FKs do what they need to do in a different way. I guess it depends on whether we can take shortcuts with DELETEs and FK CASCADEs accumulating in the same editor, or if those have to be applied sequentially in different working sets.

[mlucic]

CC @max-hoffman since you implemented the fix for the related issue