Vitess protocol buffer namespace conflict

[dolthub]

Vitess protocol buffer namespace conflict

[ryanpbrewster]

Confirming that when I upgrade from

dolthub/[email protected]

to

dolthub/go-mysql-server@707f05909f9544d323f6223948ec01e686d18a37

(the commit from a few hours ago)
the sample test I provided above now passes

$ go test foo_test.go 
ok      command-line-arguments  0.005s

[ryanpbrewster]

I managed to reproduce this from within this repo, and in the process discovered that my proposed fix is not quite sufficient. The protoregistry actually expects all .proto files to have globally unique files paths relative to their proto root. In this repo's case, the proto root is proto/, so proto/topodata.proto will conflict with any other topodata.proto that exists in any other dependency.

I think there is a very simple fix here: move all the proto files from proto/*.proto to proto/dolthub/vt/*.proto. That ensures that they will only conflict with other projects that also lay out their protos in proto/dolthub/vt/ directory structure.

[ryanpbrewster]

Fixed by #166