Error while accessing from Linux env

[domaintools]

Error while accessing from Linux env

[patilnikhilh80]

if anyone can help
@ChuckWoodraska @jmeridth @timothycrosley

[jmeridth]

@patilnikhilh80 Can you please provide the code snippet you're using that works on windows but fails on Linux? My first thought is a path issue. But your snippet will help confirm my suspicion.

Please note that I don't work for DomainTools anymore but willing to help.

[patilnikhilh80]

Line where I get error in mywork.py
riskscore = json.loads(str(self.domaintools_client.risk(url)))
domaintools_client is

import domaintools
import requests
class DomainToolsClient:

    def __init__(self, api_name, api_key, proxy=None):
        self.api_name = api_name
        self.api_key = api_key
        self.proxy = None
        self.api = domaintools.API(self.api_name, self.api_key)
        if proxy:
            self.proxy = {"https_proxy": proxy}
            self.api = domaintools.API(self.api_name, self.api_key, proxy_url=proxy, verify_ssl=False)

    def investigate(self, domain):
        params = {"api_username": self.api_name,
                  "api_key": self.api_key}
        res = requests.get(f"https://api.domaintools.com/v1/iris-investigate/{domain}", params=params,
                           proxies=self.proxy)
        return res.json()

    def risk(self, domain):
        return self.api.risk(domain)

@jmeridth

[patilnikhilh80]

This issue was caused because of improper proxy settings.
Generally we set proxies as dictionary, but here we need to set it as string,
Ex. Generally
proxy = {'http': 'something', 'https': 'something'}In this case
proxy = 'something'

It too so long to identify its a proxy issue due to improper error handling in package. Difficult to find out from following error.

AttributeError: 'dict' object has no attribute 'decode'
'dict' object has no attribute 'decode'

maybe we can improve the error msg to understand it more easily. Like invalid proxy or something.

Can I open PR, seems don't have access though.

[jmeridth]

@patilnikhilh80 nice catch.

You can fork the repository and issue a pull request from there. You won't have access to create a branch on this repo directly.

[mccarthym]

Thank you for the comment @patilnikhilh80, per @ChuckWoodraska's comment above, we've tried to improve our messaging for issues such as this.