Comments (6)
The license is included at the bottom of the README file. The packaging guidelines you listed have no requirement that the license be in its own file. It only says "If the source package does not include the text of the license(s), the packager should contact upstream and encourage them to correct this mistake." But since the source package does include in the text of the license, we're in the clear.
from php-scrypt.
Yes, sorry, I miss it.
But, the README is mostly a "INSTALL" file. So its content have no interest to be packaged (when the package is installed, those instruction are no more usefull).
The reason why it is cleaner to have separate README, INSTALL, POSTINSTALL, LICENSE files.
But, we can live with a single file...
from php-scrypt.
I would suggest to follow @remicollet advice.
We will certainly add some checks soon to pecl.php.net to reject a release if LICENSE is missing.
from php-scrypt.
@pierrejoye I was under the impression that pecl checked the package.xml file for the license?
from php-scrypt.
not for the LICENSE file.
On Mon, Oct 7, 2013 at 10:08 AM, Dominic Black [email protected]:
@pierrejoye https://github.com/pierrejoye I was under the impression
that pecl checked the package.xml file for the license?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/19#issuecomment-25790965
.
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org
from php-scrypt.
Additional note : the README.md and CREDITS files should also role="doc"
from php-scrypt.
Related Issues (20)
- Empty key length does not return any errors - just a blank hash.
- Segfault in php-scrypt/crypto/crypto_scrypt-sse.c:337 HOT 2
- Compilation error with GCC 4.9 - inlining fail HOT 2
- Default hash length is twice what it needs to be HOT 12
- Compilation failure, CPU without SSE2 support. HOT 5
- PHP 7 Support HOT 22
- Hash identifying? HOT 1
- manual install (windows) HOT 1
- Weak CSPRNG for the salt in some situations. HOT 9
- 1.4: failed test
- Show salt in hex instead of binary HOT 3
- Add needsRehash function HOT 3
- 算法结果去期望值不相同 HOT 1
- PHP package cannot be found after php extension installation
- can't install php-scrypt
- scrypt hash looks different in PHP72 and PHP74 HOT 1
- [bug] Salt param is being ignored in Windows
- Replacement in Sodium? HOT 1
- Please release fix for PHP 8.0 HOT 5
- Attempting to compile with SSE support on non-supported archetectures HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-scrypt.