Comments (4)
Darn, I thought I fixed this.
While of course it is a bug in your code if you reject with a non-Error
instance, this is indeed something Chai as Promised should catch. I'll try to track this down sometime during the next few weeks, but conferences will be keeping me busy, so pull request appreciated if you'd like it fixed sooner :)
from chai-as-promised.
My mistake, the bug seems to be in Mochas testrunner. This yields the same result (without involvement of chai or chai-as-promised).:
it('Should fail if rejected with no value ', function () {
return Q.reject();
});
Closing this issue.
from chai-as-promised.
Hmm right, yeah I think it is because Mocha bottoms out at the done
style, and
it('should fail if called with an error that is undefined', function (done) {
done(undefined);
});
counts as a success. In theory they should handle this better for promises.
That said, Chai as Promised should be able to handle this, as Chai as Promised doesn't communicate the original rejection directly to Mocha. Reopening for future fix.
from chai-as-promised.
I'm rolling up all bugs in the category "isRejected/rejectedWith doesn't behave like Chai's error rejectors" into #166.
from chai-as-promised.
Related Issues (20)
- should.eventually.be.<boolean> and should.eventually.equal(<boolean>) HOT 1
- Provide browser script HOT 1
- Error: Invalid Chai property: _promise
- not compatible with chai-arrays
- expect(...).to.be.rejected always passes HOT 2
- rejectedWith when error is undefined doesn't work
- rejectedWith Deep Equals
- Implementation of to.eventually.be.pending
- Proxying makes use order matter with chai-exclude and chai-as-promised HOT 1
- node 15, eventually.throw ? HOT 2
- Printing stacktrace whenever a promise is rejected HOT 1
- Does not work well with bluebird.
- rejectedWith not checking the error message HOT 3
- Syntax Error: /node_modules/chai-as-promised/lib/chai-as-promised.js:5:1 HOT 1
- Duplicate packages detected in the chaiaspromised project on Tag: v7.1.1
- .eventually assertion doesn't fail when Error message mismatch. HOT 2
- Asserting a rejcted promise to not be rejected succeeds HOT 1
- Overloading `rejectedWith` to handle `undefined` input
- Feature request: Support for es6 modules HOT 1
- Chai v5 support HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chai-as-promised.