Giter Site home page Giter Site logo

Comments (4)

domenic avatar domenic commented on June 19, 2024

Darn, I thought I fixed this.

While of course it is a bug in your code if you reject with a non-Error instance, this is indeed something Chai as Promised should catch. I'll try to track this down sometime during the next few weeks, but conferences will be keeping me busy, so pull request appreciated if you'd like it fixed sooner :)

from chai-as-promised.

tidlund avatar tidlund commented on June 19, 2024

My mistake, the bug seems to be in Mochas testrunner. This yields the same result (without involvement of chai or chai-as-promised).:

it('Should fail if rejected with no value ', function () {
    return Q.reject();
});

Closing this issue.

from chai-as-promised.

domenic avatar domenic commented on June 19, 2024

Hmm right, yeah I think it is because Mocha bottoms out at the done style, and

it('should fail if called with an error that is undefined', function (done) {
  done(undefined);
});

counts as a success. In theory they should handle this better for promises.


That said, Chai as Promised should be able to handle this, as Chai as Promised doesn't communicate the original rejection directly to Mocha. Reopening for future fix.

from chai-as-promised.

domenic avatar domenic commented on June 19, 2024

I'm rolling up all bugs in the category "isRejected/rejectedWith doesn't behave like Chai's error rejectors" into #166.

from chai-as-promised.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.