False Error node version should be ok; it is not OLD

[donPab]

False Error node version should be ok; it is not OLD

[donPab]

I just patched bundle.js and then ran it.
== results

✓  shell
    found at "C:/WINDOWS/SYSTEM32/CMD.EXE"
✓  node
    found at "C:/PROGRAM FILES/NODEJS/NODE.EXE" (v18.14.0 satisfies >=16)
✓  npm
    found at "C:/PROGRAM FILES/NODEJS/NPM.CMD"

SUCCESS! All system dependencies seem to be in order.

I don't know anything about PR.
Creating extensions and regression testing on VSCode is beyond my experience and pay grade.
I leave it to you to incorporate this change.
tkx, donPab

[donPab]

It would seem to my untrained eyes that the default--
export const DefaultNodeVersion = '16';

might be changed to something like--
export const DefaultNodeVersion = '>=16.0.0';

and let semver.satisfies do a proper compare??

[Domiii]

Related to #593.
Version 16 is currently hardcoded in this line of code.

• I'd recommend, either change that line or downgrade to 16 using volta or nvm.
• The better fix would be to change requirements to check for "greater or equal" instead of "equal".

Also: Can't you just say "keep going" even with the warning? That theoretically should be possible, but maybe there is a small bug.

[Domiii]

It would seem to my untrained eyes that the default-- export const DefaultNodeVersion = '16';

might be changed to something like-- export const DefaultNodeVersion = '>=16.0.0';

and let semver.satisfies do a proper compare??

If that works, sure! Please test and file a PR if it works🙏 😄