Comments (4)
I just patched bundle.js and then ran it.
== results
✓ shell
found at "C:/WINDOWS/SYSTEM32/CMD.EXE"
✓ node
found at "C:/PROGRAM FILES/NODEJS/NODE.EXE" (v18.14.0 satisfies >=16)
✓ npm
found at "C:/PROGRAM FILES/NODEJS/NPM.CMD"
SUCCESS! All system dependencies seem to be in order.
I don't know anything about PR.
Creating extensions and regression testing on VSCode is beyond my experience and pay grade.
I leave it to you to incorporate this change.
tkx, donPab
from dbux.
It would seem to my untrained eyes that the default--
export const DefaultNodeVersion = '16';
might be changed to something like--
export const DefaultNodeVersion = '>=16.0.0';
and let semver.satisfies do a proper compare??
from dbux.
Related to #593.
Version 16 is currently hardcoded in this line of code.
- I'd recommend, either change that line or downgrade to 16 using
volta
ornvm
. - The better fix would be to change requirements to check for "greater or equal" instead of "equal".
Also: Can't you just say "keep going" even with the warning? That theoretically should be possible, but maybe there is a small bug.
from dbux.
It would seem to my untrained eyes that the default--
export const DefaultNodeVersion = '16';
might be changed to something like--
export const DefaultNodeVersion = '>=16.0.0';
and let semver.satisfies do a proper compare??
If that works, sure! Please test and file a PR if it works🙏 😄
from dbux.
Related Issues (20)
- Fix moduleFilters: files are logged multiple times
- fix and improve value rendering HOT 2
- feature: Dynamically enabling Dbux
- Better labels for DataFlow view HOT 1
- fix: more small call graph and call stack and more things
- [Bug] dbux is assuming `bash` in Windows resolves to MINGW/MSYS bash HOT 27
- feature: support correct call graphs for generator and async generator functions HOT 1
- ✅Checklist✅: Pathways + User Feedback Collection (2022/4)
- [Bug] Dbux does not deal well with erroneous getters
- Some more generator functions stuff, generator-try-catch etc.
- Check and fix Tutorial + Survey
- Add proper config file support
- Improve encoding/decoding performance
- Reduce post-deployment dependencies
- Feature: Data Dependency Graph (DDG) HOT 1
- feature: DDG control comprehension HOT 1
- fix: tests are sometimes not picked up correctly (`dpMaximumSubarray`) HOT 1
- Wrong version of node ?? HOT 1
- [Bug] SyntaxError: Identifier '_class' has already been declared HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dbux.