creationix/jsonparse bumped to 0.0.5

[dominictarr]

creationix/jsonparse bumped to 0.0.5

[dominictarr]

cool, fixed in 0.4.4

[dominictarr]

tests are passing for me, are you sure you are running tests on master?

[jlank]

Thought I was, just did a clone which would have put me on the master branch-- not at the keys right now but ill check again later when I am and let you know what I see.

On Mar 14, 2013, at 5:46 PM, Dominic Tarr [email protected] wrote:

tests are passing for me, are you sure you are running tests on master?

—
Reply to this email directly or view it on GitHub.

[jlank]

Ok so I get an error -- test/multiple_objects_error.js -- with npm test in [email protected] on node v0.8.9, and on v0.10.0 the tests freeze. This is the same error I see when the jsonparse dep is 0.0.5.

v0.8.9

⚡ node -e "console.log(process.versions)"
{ http_parser: '1.0',
  node: '0.8.9',
  v8: '3.11.10.22',
  ares: '1.7.5-DEV',
  uv: '0.8',
  zlib: '1.2.3',
  openssl: '1.0.0f' }

jlank in ~/tmp/JSONStream on master*
⚡ npm test

> JSONStream@0.4.3 test /Users/johnlancaster/tmp/JSONStream
> set -e; for t in test/*.js; do echo '***' $t '***'; node $t; done

*** test/bool.js ***
PASSED
*** test/destroy_missing.js ***
PASSED
*** test/empty.js ***
PASSED
*** test/fn.js ***
PASSED
*** test/multiple_objects.js ***
END
*** test/multiple_objects_error.js ***
[Error: Unexpected RIGHT_BRACE("}") in state VALUE]
*** test/parsejson.js ***
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
correct 0.9337508901953697
parsed 0.9337508901953697
parsed [ 0.9337508901953697 ]
*** test/stringify.js ***
PASSED
*** test/stringify_object.js ***
PASSED
*** test/test.js ***
PASSED
*** test/test2.js ***
PASSED
*** test/two-ways.js ***
PASSED

v0.10.0

⚡ node -e "console.log(process.versions)"
{ http_parser: '1.0',
  node: '0.10.0',
  v8: '3.14.5.8',
  ares: '1.9.0-DEV',
  uv: '0.9',
  zlib: '1.2.3',
  openssl: '1.0.1e' }

jlank in ~/tmp/JSONStream on master*
⚡ npm test

> JSONStream@0.4.3 test /Users/johnlancaster/tmp/JSONStream
> set -e; for t in test/*.js; do echo '***' $t '***'; node $t; done

*** test/bool.js ***
PASSED
*** test/destroy_missing.js ***

freezes there

[dominictarr]

that is not an error in the 0.8 version, if it's an error, the test multiple_objects_error.js will exit non zero,
and the test run will stop.

That is an error on the 0.10 test, though. Streams2 changes the meaning of destroy() and 'close'
I've updated the test, and it passes now.

[dominictarr]

Also, this now uses through internally, so it uses backpressure correctly, and buffers.