Comments (3)
I'm not aware of any precedent for comma-separated generator strings, and I'm hesitant to invent one... I think this is kind of what XMP's 'ingredient' concept was made for, but it's complicated and subjective enough (discussed in #1367) that I don't think glTF Transform should try to do that in merge() automatically.
Is this a problem for your use case? My hunch is that your application knows better than glTF Transform can know, whether one generator string should win, or whether concatenating them is meaningful... It might be best to assign the generator string directly in the script above.
In terms of the default behavior — I'm tempted to say that the original generator string on the document should be kept, and not modified in a merge, which feels more semantically defensible than last-document-in-wins.
One could also argue that the generator should be "glTF Transform". ;)
from gltf-transform.
The comma-separated list was just an overly suggestive attempt to "retain all information" (with the obvious caveats).
I'd also agree that keeping the generator of the target document when merging in others could make more sense. (And that's what I assumed to happen ... but... fixed it...). Justifications for that could be...
- the order in which documents are merged into a target should not matter
- the document that others are merged in is usually generated by glTF-Transform (if it was created from scratch)
But I don't have a strong opinion about the solution. Knowing what the behavior is allows users to set the generator as they see fit, and I just wanted to bring it up. (So the issue could be closed if there's no strong reason to change anything).
from gltf-transform.
Proposed solution:
tl;dr - a.merge(b)
is replaced by mergeDocuments(a, b)
. The generator string of the target document will be kept when merging, along with other root-level properties. For more granular control, the new copyToDocument(target, source, sourceProperties)
function may be used instead.
from gltf-transform.
Related Issues (20)
- ktx resize not work as intended HOT 1
- Expose simplifyRatio to the optimize CLI HOT 2
- How to add prefix to baseColor_xx.jpg?
- Invalid bounding box calculation when one of the meshes lacks a POSITION attribute. HOT 3
- An option to keep separate buffer views when doing `meshopt` HOT 7
- Race condition in toKtx.ts HOT 3
- Merging documents with extensions HOT 7
- Cache cleanup HOT 2
- Draco compression may produce an UNSIGNED_SHORT index buffer with vertex count > 65535 HOT 3
- Change default compression with 'optimize' CLI to Meshopt
- `partition` command is slow for large models HOT 6
- Simplify Draco and Meshopt compression implementations
- Prune fails to clean up accessors referenced by non-root properties HOT 2
- VRM gets treated as glTF instead of GLB HOT 11
- Serialization format for transforms HOT 2
- Roadmap for '@gltf-transform/view' package
- Quantization creates invalid skinning weights for CesiumMan.glb
- Support transforms reporting a 'skip' result
- Minor glitch in documentation typings HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gltf-transform.