Giter Site home page Giter Site logo

Comments (4)

nbulaj avatar nbulaj commented on July 17, 2024

Hey @denisahearn

Do you still have an issue when upgrading to Doorkeeper 5.6.6 ?

from doorkeeper.

denisahearn avatar denisahearn commented on July 17, 2024

@nbulaj Yes, the same issue happens with doorkeeper 5.6.6. In fact that's the version we tried upgrading to yesterday when we experienced the issue. I isolated 5.6.3 as the version that introduced the issue.

from doorkeeper.

nbulaj avatar nbulaj commented on July 17, 2024

Could be related to changes in config evaluation, but it's always so hard to debug such things unfortunately
https://github.com/doorkeeper-gem/doorkeeper/pull/1627/files

from doorkeeper.

AmShaegar13 avatar AmShaegar13 commented on July 17, 2024

Hey @nbulaj

I ran into a similar problem with assets:precompile and doorkeeper. I run precompile in a CI context where there is no database configuration available so it fails when it tries to access certain environment variables in config/database.yml which shouldn't be loaded at all. This is called by the same lines in doorkeeper like for @denisahearn.

To me it looks like orm hooks are run too early and we need to lazy load here as well because access_token_class.constantize in lib/doorkeeper/config.rb:434 loads ActiveRecord::Base too early. I tried to do so by wrapping it like so lib/doorkeeper/engine.rb:23:

    config.to_prepare do
      ActiveSupport.on_load(:active_record) do
        Doorkeeper.run_orm_hooks
      end
    end

At least this fixed the problem for me while keeping everything else functional. However, I am not an expert regarding Rails internals or doorkeeper. I am using doorkeeper for the first time here.

Maybe this helps you isolate or even fixes the problem. :)

from doorkeeper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.