Comments (4)
Hey @denisahearn
Do you still have an issue when upgrading to Doorkeeper 5.6.6 ?
from doorkeeper.
@nbulaj Yes, the same issue happens with doorkeeper 5.6.6. In fact that's the version we tried upgrading to yesterday when we experienced the issue. I isolated 5.6.3 as the version that introduced the issue.
from doorkeeper.
Could be related to changes in config evaluation, but it's always so hard to debug such things unfortunately
https://github.com/doorkeeper-gem/doorkeeper/pull/1627/files
from doorkeeper.
Hey @nbulaj
I ran into a similar problem with assets:precompile and doorkeeper. I run precompile in a CI context where there is no database configuration available so it fails when it tries to access certain environment variables in config/database.yml which shouldn't be loaded at all. This is called by the same lines in doorkeeper like for @denisahearn.
To me it looks like orm hooks are run too early and we need to lazy load here as well because access_token_class.constantize
in lib/doorkeeper/config.rb:434 loads ActiveRecord::Base too early. I tried to do so by wrapping it like so lib/doorkeeper/engine.rb:23:
config.to_prepare do
ActiveSupport.on_load(:active_record) do
Doorkeeper.run_orm_hooks
end
end
At least this fixed the problem for me while keeping everything else functional. However, I am not an expert regarding Rails internals or doorkeeper. I am using doorkeeper for the first time here.
Maybe this helps you isolate or even fixes the problem. :)
from doorkeeper.
Related Issues (20)
- Do not recommend setting access_token_expires_in to nil HOT 1
- It is not possible to revoke refresh token bound to the expired access token HOT 3
- Enhancement: expose `current_resource_owner` to views
- Better support for credential rotation
- Always requiring `redirect_uri` is not compliant to RFC 6749 HOT 2
- NotImplementedError error response must define #exception_class after upgrading to 5.6.7 from 5.6.6 HOT 4
- NoMethodError: undefined method `name_for_response' since v5.6.8 HOT 3
- Doorkeeper::Errors::InvalidRedirectUri Raised When No Redirect URI Set HOT 2
- OpenId Connect - No e-mail information in the SSO response
- How do I know if an application has been authorized by a resource owner? HOT 1
- Regression with Errors in 5.6.8 HOT 5
- Refreshing a token sending scopes separated by `+` does not work
- Cleanup job removes not expired tokens HOT 1
- Different access grants return the same access token with `reuse_access_token` enabled
- Removing active_record_options was a breaking change HOT 1
- `Doorkeeper::AccessToken.find_or_create_for` with empty scopes raises NoMethodError HOT 6
- Token revocation error when token contains null byte. HOT 2
- Doorkeeper is loading ActiveRecord too early HOT 1
- AuthorizedApplications returns the date that the _application_ was created, not the date that the _authorization_ was created HOT 1
- Add GitHub Discussions to the project HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doorkeeper.