mkfs.fat: automatic FAT32 selection

[dosfstools]

mkfs.fat: automatic FAT32 selection

[andreasbombe]

Do you have a specific example of the happening in the real world?

If no FAT size is specified and the target is 512 MiB or larger in size, FAT32 is automatically selected in establish_params(). The comment should therefore probably deleted.

[japm48]

Ah, OK then.
I was reading that to implement some basic filesystem detection.
Anyways, the check is in the total size, not the number of sectors, but with a default of 512 bytes per sector, I guess it's correct in the default case.
Another comment says This only works correctly for 512 byte sectors!, probably hints that some OSs could misdetect the fs type. I'll to do some calculations to see if a non-conforming partition can be generated with the defaults.

So, I'd better investigate what Windows format is doing. Maybe they don't even respect their own rules.

Sorry for the noise, and please remove the misleading comment.
Feel free to close this, I'll reopen if I come up with a better implementation idea.

[andreasbombe]

The code base is really quite old and not all that easy to follow the way it has grown back then. This particular selection being split over two function is really not so great. At least there's already checks whether the cluster count matches the requested FAT size, so if there was a mistake, it would be reported.

For now, I've just changed the comment.