Improve window resizing when using WindowEx Persistence

[dotmorten]

Improve window resizing when using WindowEx Persistence

[dotMorten]

I just figured it out! If I restore position when I receive the WM_SHOWWINDOW message, there's no visible jump.

[dotMorten]

I’ve tried but failed. Perhaps @marb2000 can suggest the right time to do this?

[mikebattista]

@rkarman do you have any guidance here? The window size and position are getting loaded with the below. We're wondering if there's a better way to do this so all the window resizing is handled before we show anything to the user.

WinUIEx/src/WinUIEx/WindowManager.cs

Lines 78 to 88 in ac3fe32

	private void Window_Activated(object sender, WindowActivatedEventArgs args)
	{
	_window.Activated -= Window_Activated;
	_window.DispatcherQueue.TryEnqueue(Microsoft.UI.Dispatching.DispatcherQueuePriority.High, () =>
	{
	LoadPersistence();
	InitBackdrop();
	});
	if (BackdropConfiguration != null)
	BackdropConfiguration.IsInputActive = args.WindowActivationState != WindowActivationState.Deactivated;
	}

WinUIEx/src/WinUIEx/WindowManager.cs

Lines 241 to 293 in 9e4beb4

	private void LoadPersistence()
	{
	if (!string.IsNullOrEmpty(PersistenceId))
	{
	try
	{
	if (ApplicationData.Current?.LocalSettings?.Containers is null ||
	!ApplicationData.Current.LocalSettings.Containers.ContainsKey("WinUIEx"))
	return;
	byte[]? data = null;
	var winuiExSettings = ApplicationData.Current.LocalSettings.CreateContainer("WinUIEx", ApplicationDataCreateDisposition.Existing);
	if (winuiExSettings is not null && winuiExSettings.Values.ContainsKey($"WindowPersistance_{PersistenceId}"))
	{
	var base64 = winuiExSettings.Values[$"WindowPersistance_{PersistenceId}"] as string;
	if(base64 != null)
	data = Convert.FromBase64String(base64);
	}
	if (data is null)
	return;
	// Check if monitor layout changed since we stored position
	var monitors = MonitorInfo.GetDisplayMonitors();
	System.IO.BinaryReader br = new System.IO.BinaryReader(new System.IO.MemoryStream(data));
	int monitorCount = br.ReadInt32();
	if (monitorCount < monitors.Count)
	return; // Don't restore - list of monitors changed
	for (int i = 0; i < monitorCount; i++)
	{
	var pMonitor = monitors[i];
	if (pMonitor.Name != br.ReadString() ||
	pMonitor.RectMonitor.Left != br.ReadDouble() ||
	pMonitor.RectMonitor.Top != br.ReadDouble() ||
	pMonitor.RectMonitor.Right != br.ReadDouble() ||
	pMonitor.RectMonitor.Bottom != br.ReadDouble())
	return; // Don't restore - Monitor layout changed
	}
	int structSize = Marshal.SizeOf(typeof(WINDOWPLACEMENT));
	byte[] placementData = br.ReadBytes(structSize);
	IntPtr buffer = Marshal.AllocHGlobal(structSize);
	Marshal.Copy(placementData, 0, buffer, structSize);
	var retobj = (WINDOWPLACEMENT)Marshal.PtrToStructure(buffer, typeof(WINDOWPLACEMENT))!;
	Marshal.FreeHGlobal(buffer);
	// Ignore anything by maximized or normal
	if (retobj.showCmd == SHOW_WINDOW_CMD.SW_INVALIDATE && retobj.flags == WINDOWPLACEMENT_FLAGS.WPF_RESTORETOMAXIMIZED)
	retobj.showCmd = SHOW_WINDOW_CMD.SW_MAXIMIZE;
	else if (retobj.showCmd != SHOW_WINDOW_CMD.SW_MAXIMIZE)
	retobj.showCmd = SHOW_WINDOW_CMD.SW_NORMAL;
	_restoringPersistance = true;
	Windows.Win32.PInvoke.SetWindowPlacement(new Windows.Win32.Foundation.HWND(_window.GetWindowHandle()), in retobj);
	_restoringPersistance = false;
	}
	catch { }
	}
	}

[mikebattista]

Awesome!