I'm getting unwanted navigation when holding `Ctrl` and hovering over operators like `&&` or `>`. Not sure if caused by this PR or a bug in VS.

[vzarytovskii]

I'm getting unwanted navigation when holding `Ctrl` and hovering over operators like `&&` or `>`. Not sure if caused by this PR or a bug in VS.

[vzarytovskii]

Are they clicking while holding Ctrl? If so, this is by design. Ctrl-click navigates you to the thing under the caret.

I believe there is a setting for this in vs if the user doesn't like that behavior.

I believe it's just hovering, @majocha may confirm/deny it.

[majocha]

Yes, it's just hover.

More interestingly, if you enable "View > Code Definition Window", the unwanted navigation can happen just with typing.

For example:

Type Console.Out. Move the cursor back with left-arrow, and bam, navigation to metadata.

I suspect the problem is that our code path for external symbols ends up calling NavigateToExternalDeclarationAsync instead of just returning a FSharpNavigableItem array.

VS calls IFSharpGoToDefinitionService.FindDefinitionsAsync -> the symbol is external -> we end up here:

fsharp/vsintegration/src/FSharp.Editor/Navigation/GoToDefinition.fs

Line 784 in 6420e36

gtd.NavigateToExternalDeclarationAsync(targetSymbolUse, metadataReferences)

[majocha]

Just hovering over external symbol, (not just operators) while holding Ctrl causes VS (Roslyn?) to call IFSharpGoToDefinitionService.FindDefinitionsAsync.

Which in turn calls NavigateToExternalDeclarationAsync:

fsharp/vsintegration/src/FSharp.Editor/Navigation/GoToDefinition.fs

Lines 775 to 789 in 6420e36

	member _.FindDefinitionsAsync(position) =
	cancellableTask {
	let gtd = GoToDefinition(metadataAsSource)
	let! result = gtd.FindDefinitionAtPosition(initialDoc, position)
	match result with
	| ValueSome(FSharpGoToDefinitionResult.NavigableItem(navItem), _) -> return ImmutableArray.create navItem
	| ValueSome(FSharpGoToDefinitionResult.ExternalAssembly(targetSymbolUse, metadataReferences), _) ->
	do!
	gtd.NavigateToExternalDeclarationAsync(targetSymbolUse, metadataReferences)
	|> CancellableTask.ignore
	return ImmutableArray.empty
	| _ -> return ImmutableArray.empty
	}

Somehow this doesn't happen that often with vsix built from main, but I can repro this in debug mode each time.

[vzarytovskii]

Yeah, that's definitely either VS or Roslyn. @CyrusNajmabadi is it something you can control?

[CyrusNajmabadi]

Are they clicking while holding Ctrl? If so, this is by design. Ctrl-click navigates you to the thing under the caret.

I believe there is a setting for this in vs if the user doesn't like that behavior.