[Proposal] Add ReadBool and WriteBool to GpioController

[dotnet]

[Proposal] Add ReadBool and WriteBool to GpioController

[krwq]

@shaggygi you can have a ReadBool or ReadAsBool and Write with different overload. Reopening as I personally find the enum cumbersome and prefer bool and keep on noticing the pattern @joperezr mentioned more and more in the PRs - I think we should keep things as simple as possible

[krwq]

I think I'm fine with this as us after @JeremyKuhne's changes. @shaggygi? (closing this assuming you agree)

[joperezr]

I'm not sure how valuable these methods would be, since in reality you could still have the above code written in one line like:

BitArray bitArray = new BitArray(new byte[] { 0x1A });

foreach (bool bitValue in bitArray)
{
  _controller.Write(1, (bitValue) ? PinValue.High : PinValue.Low);
  
  // Other logic...
}

Granted it is not as readable as an overload, but I'm just not convinced that we should add extra methods for this. Also, if we were to add them, I would much rather just have an overload of Write that takes in a bool instead of a PinValue than having different method names.

[shaggygi]

Yeah, I originally wanted the Write/Read, but since you couldn't have a Read for returning both PinValue or a bool is why I added the Bool at end. I agree, just use the logic above will be fine. Closing.

[joperezr]

I believe that this experience should be better now that PinValue is a struct right? You should now be able to use either int or bool on the write method by just casting. @krwq do you agree that after this change we don't need these extra Apis any longer?