Giter Site home page Giter Site logo

Comments (4)

cston avatar cston commented on July 18, 2024

@oruchreis, thanks for reporting this.

The collection expression conversion requires each element in the collection to be implicitly convertible to the iteration type of the target type. Previously, the compiler ignored the strongly-typed GetEnumerator() implementation and assumed the iteration type of a type implementing IEnumerable only is object (rather than (string, uint) in this case) and that all elements were implicitly convertible to object.

Sorry for the inconvenience.

from roslyn.

oruchreis avatar oruchreis commented on July 18, 2024

@cston But the element item is not (string, uint), it is object in this case, The class is IEnumerable and not IEnumerable<(string, uint)>.

public class IpList : IEnumerable //<<
{ 

The IEnumerator<(string, uint)> GetEnumerator() method is not belong to IEnumerable interface. Shouldn't the compiler not recognise this method as part of IEnumerable? Anyway, this method does not belong to IEnumerable. So the collection expression is applied to a class that implements IEnumerable, not to a class that is IEnumerable<(string, uint).

from roslyn.

cston avatar cston commented on July 18, 2024

The iteration type used by collection expression conversions is the foreach statement iteration type which prefers the signature of the accessible GetEnumerator() method, if any, over the interface. It was an oversight that the compiler ignored the accessible GetEnumerator() method previously for the conversion and simply relied on the interface.

from roslyn.

jaredpar avatar jaredpar commented on July 18, 2024

Closing as the new behavior is "By Design".

from roslyn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.