Edit.Duplicate command does not insert trailing newline between original and duplicated code

[vsfeedback]

Edit.Duplicate command does not insert trailing newline between original and duplicated code

[sharwell]

This is a case where the command did exactly what it said it would do, but not what the user wanted. The selection did not contain a newline after } or a newline before for, so when the code was duplicated it put those two tokens on the same line.

[mstepanov214]

I expected behavior similar to VS Code. After all, your file may not contain a newline at the top or bottom.

[sharwell]

I think it's reasonable to assume that if the last selected line of a multi-line selection is a non-empty line that is fully selected except for the trailing newline, the duplicated code should be placed on the line after it.

• If the selection does not span multiple lines, the additional end-of-line should not be added, even if the selection is a complete line.
• If the last line of the selection is fully-selected but empty, it means the preceding end-of-line is already selected and there is no need to add a new one.

[CyrusNajmabadi]

@sharwell is this us? or editor?

[mstepanov214]

@sharwell
After some thought, I agree with this statement:

This is a case where the command did exactly what it said it would do

The command works according to its name. Therefore, I believe that I have not defined the problem quite correctly.

I use the Edit.Duplicate command as an analog to the editor.action.copyLinesDownAction from VS Code. It's not exactly the same thing. Perhaps it would be better to suggest implementing another command with the required functionality. I don't know.

[ToddGrun]

This is implemented by vs-platform in their DuplicateSelectionCommandHandler and the corresponding implementation in EditorOperations.DuplicateSelection. It does feel like there is some room for improvement here. @olegtk -- Do you know if this is a known issue or whether we should create a bug?

[olegtk]

It's actually by design and VS Code behaves the same way (although I don't remember why).
You are supposed to select the lines including line ending like this, then it would be duplicated as you expect.

I'll reactivate the original ticket and move it to the Editor to continue the discussion, you can close this issue now.