Giter Site home page Giter Site logo

Comments (5)

CyrusNajmabadi avatar CyrusNajmabadi commented on July 21, 2024

Having two pieces of code that are fighting over the proper indentation is not good.

Agreed. The indentation/formatting split is a nightmare that continues to plague us. Some parts are shared. but it appears as if each has codepaths that the other doesn't go through. It's not good.

from roslyn.

ToddGrun avatar ToddGrun commented on July 21, 2024

@sharwell / @CyrusNajmabadi -- Trying to triage this, and yeah, this definitely isn't great. Is there someone on the team who usually gets either formatting or smart indent bugs?

from roslyn.

CyrusNajmabadi avatar CyrusNajmabadi commented on July 21, 2024

Sam does :-). Or round robin it

from roslyn.

ToddGrun avatar ToddGrun commented on July 21, 2024

Given the disparity and complexity of both systems, making them match better feels like more than a bug level fix to me. Setting the feature label so we can address this as such.

from roslyn.

sharwell avatar sharwell commented on July 21, 2024

Well, you definitely don't want the formatter to handle this indentation case because the formatter doesn't ever do anything inside this collection initializer.

This behavior is probably triggered by a one-off TypeChar handler to cover the case of typing a { on a blank line within a collection initializer, specifically because the formatter doesn't operate at that location.

from roslyn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.