Comments (1)
Closing out as by design. Blocking this would break a ton of code. The compiler and language are properly abiding by all the rules of your code. You have a readonly varaible. So the compiler ensures it will not be mutated.
Not being mutated doesn't mean you can't perform operations on it. It just means that the storage of that struct won't actually mutate.
This behaviour not only makes ref readonly inconsistent,
This is consistent with how 'readonly' has worked since 1.0 of the language.
it's also easy to write bugs with because the changes become invisible and there isn't any warning.
Adding a warning would def break as lots of code certainly calls non-readonly methods on readonly variables today (consider all the readonly fields out there, and how many millions of methods exist that are not marked 'readonly').
That said, if you want a warning here, you could definitely easily write an analyzer that looks for this issue in your codebase and flags it for you as a domain specific problem you want to avoid.
from roslyn.
Related Issues (20)
- Create LangVersion 13 HOT 3
- [Automated] PRs inserted in VS build feature.debugger.main-35027.161
- [Automated] PRs inserted in VS build main-35027.32
- Roslyn wrote incorrect timedatestime to PE Coff Header of a .Net 8.0 program file HOT 2
- IDE0304 should preserve the leading comment HOT 5
- Support limiting CS1591 to certain members
- [Automated] PRs inserted in VS build main-35028.101
- IDE0161 - Convert to file-scoped namespace reported on files with global namespace type declarations
- Rename 'class1' to 'Class1' lingers after IDE1006 fixer
- IDE0059 is not raised inside a code block with using keyword.
- Go To Definition on external package only works as expected the very first time HOT 1
- Partial properties needs to enforce that all implementation part accessors have bodies
- Suppress No Longer Showing in Error List HOT 1
- [Automated] PRs inserted in VS build feature.debugger.main-35101.127
- Duplicate item metadata present in generated editorconfig with CompilerVisibleItemMetadata
- 'dotnet_style_require_accessibility_modifiers = always' doesn't work for interface members
- IDE0040 (Add accessibility modifiers) is not enforced for types nested in interfaces
- An instance of analyzer System.Text.Json.SourceGeneration.JsonSourceGenerator cannot be created from C:\ Users\sacsharm\.nuget\packages\system.text.json\6.0.0\analyzers\dotnet\roslyn3.11\cs\System.Text.Json.SourceGeneration.dll HOT 1
- IntelliCode-suggested completions don't escape keywords properly HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roslyn.