Giter Site home page Giter Site logo

Calling non `readonly` method on `ref readonly` variable is allowed and Compiler creates a copy, making changes invisible to the user without any warning about roslyn HOT 1 CLOSED

BoyBaykiller avatar BoyBaykiller commented on July 4, 2024
Calling non `readonly` method on `ref readonly` variable is allowed and Compiler creates a copy, making changes invisible to the user without any warning

from roslyn.

Comments (1)

CyrusNajmabadi avatar CyrusNajmabadi commented on July 4, 2024

Closing out as by design. Blocking this would break a ton of code. The compiler and language are properly abiding by all the rules of your code. You have a readonly varaible. So the compiler ensures it will not be mutated.

Not being mutated doesn't mean you can't perform operations on it. It just means that the storage of that struct won't actually mutate.

This behaviour not only makes ref readonly inconsistent,

This is consistent with how 'readonly' has worked since 1.0 of the language.

it's also easy to write bugs with because the changes become invisible and there isn't any warning.

Adding a warning would def break as lots of code certainly calls non-readonly methods on readonly variables today (consider all the readonly fields out there, and how many millions of methods exist that are not marked 'readonly').

That said, if you want a warning here, you could definitely easily write an analyzer that looks for this issue in your codebase and flags it for you as a domain specific problem you want to avoid.

from roslyn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.