[4.1.1] updateMetadataForTrack accidentally clears artwork on Android

[DennisdeWitNL]

[4.1.1] updateMetadataForTrack accidentally clears artwork on Android

[DennisdeWitNL]

@Vashiru Because you are firing the command every few seconds and the artist and title did not change yet.

You could first check if the artist and title ar not the same as the values the activeTrack already have. If they are the same, do nothing. If they are not the same, then update the values.

   const activeTrack = await TrackPlayer.getActiveTrack();

    if (activeTrack?.title != obj?.songtitle) {

          TrackPlayer.updateMetadataForTrack(currentTrack, {
            title: obj.songtitle,
            artwork: require('./assets/afterhours-fm.jpg'),
          });

     } else {
      console.log("Not updating metadata yet");

   }
  }

Something like that. That's how I worked around this problem.

[Vashiru]

I think I've found a workaround just now:

If I call both updateMetadataForTrack and updateNowPlayingMetadata, my artwork will actually stay:

TrackPlayer.updateMetadataForTrack(currentTrack, {
  title: obj.songtitle,
  artwork: require('./assets/afterhours-fm.jpg'),
});
TrackPlayer.updateNowPlayingMetadata({
  title: obj.songtitle,
  artwork: require('./assets/afterhours-fm.jpg'),
});

Edit: but adding your code in as an optimization is probably a good idea.

Edit2: The issue is specifically in updateMetadataForTrack, if I don't set artwork there, but always call it in updateNowPlayingMetadata, it doesn't disappear either.

[lovegaoshi]

i can see this in example by just commenting out title and duration in onUpdateCurrentTrackMetadata(). it only messes up when replacing currentIndex Tracks.
though I dont see the same behavior for onUpdateNotificationMetadata() though, so my suggestion is check TP.currentIndex and use updateNowPlayingMetadata if === current index. otherwise I can do this in the js TP module, unless someone wants to try figuring this out in KA
i see one uses
notificationManager.overrideAudioItem = overrideAudioItem
the other uses
player.notificationManager.overrideMetadata(track.toAudioItem())
which should be the same thing

[DennisdeWitNL]

Thanks, @lovegaoshi , I will try that tomorrow. Although I am not sure how to get the TP.currentIndex? What is the function I should use for that? :)

[lovegaoshi]

await tp. getActiveTrackIndex()

…

On Wed, Apr 3, 2024, 2:00 PM DennisdeWitNL ***@***.***> wrote: Thanks, @lovegaoshi <https://github.com/lovegaoshi> , I will try that tomorrow. Although I am not sure how to get the TP.currentIndex? What is the function I should use for that? :) — Reply to this email directly, view it on GitHub <#2287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZMOVVWNWSNYNDDZDCCFKYTY3RUXPAVCNFSM6AAAAABFVUZR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVGU4DEMJYHE> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[DennisdeWitNL]

@lovegaoshi Unfortunately, both functions render the same issue.

This is the code I have used

      TrackPlayer.updateNowPlayingMetadata({
        artist: streamValues.song_artist,
        title: streamValues.song_title,
        artwork: streamValues.song_artwork,
      });

[lovegaoshi]

well, i actually dont see any problem on my end if artist and title are also set. so you're probably looking at a different issue than what i observed, unless you have a repo from the example i'm at a dead end.
my repo for the bug i described:
https://github.com/lovegaoshi/react-native-track-player/tree/bug-notif-artwork

[DennisdeWitNL]

Hi @lovegaoshi, yes. We tried this before. You can change the title to ‘foo’, and the artist to ‘foo’, too.

If these fields stay the same, the artwork blanks out. When title and artist are regenerated, there’s no problem. What comes to my mind for now is making a workaround that checks if the new info is the same as the old info, before invoking the updateMetadata command.

[lovegaoshi]

hmm. still cant reproduce. see if that repo above bugs on your end.

[DennisdeWitNL]

So, for now I have worked my way around this issue, by reading the previous issue once again.

Still needs to be solved, but at least I can work around it now.

[lovegaoshi]

are you sure you are running tje **example** app following tje instructions in that folder?

…

On Thu, Apr 4, 2024, 12:38 AM DennisdeWitNL ***@***.***> wrote: So, for now I have worked my way around with this code: const updateMetadata = async (streamValues) => { const activeTrack = await TrackPlayer.getActiveTrack(); if (activeTrack?.artist != streamValues.artist && activeTrack?.title != streamValues.title) { console.log("Updating metadata") const currentTrack = await TrackPlayer.getActiveTrackIndex(); if (currentTrack == null) { // getStreamInfoAndTriggerInitTrackPlayer(); } else { TrackPlayer.updateMetadataForTrack(currentTrack, { artist: streamValues.artist, title: streamValues.title, artwork: streamValues.artwork, }); } } else { console.log("doing nothing") } } It seems it clears out the artwork when the title and artist are still the same. So I will only update the metadata when all new info is available. That works fine. :) Still needs to be solved, but at least I can work around it now. — Reply to this email directly, view it on GitHub <#2287 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZMOVVUASIQ55SYJTE5ZHP3Y3T7OTAVCNFSM6AAAAABFVUZR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGQYTENJSGI> . You are receiving this because you were mentioned.Message ID: ***@***.*** com>

[DennisdeWitNL]

are you sure you are running tje example app following tje instructions in that folder?
…
On Thu, Apr 4, 2024, 12:38 AM DennisdeWitNL @.> wrote: So, for now I have worked my way around with this code: const updateMetadata = async (streamValues) => { const activeTrack = await TrackPlayer.getActiveTrack(); if (activeTrack?.artist != streamValues.artist && activeTrack?.title != streamValues.title) { console.log("Updating metadata") const currentTrack = await TrackPlayer.getActiveTrackIndex(); if (currentTrack == null) { // getStreamInfoAndTriggerInitTrackPlayer(); } else { TrackPlayer.updateMetadataForTrack(currentTrack, { artist: streamValues.artist, title: streamValues.title, artwork: streamValues.artwork, }); } } else { console.log("doing nothing") } } It seems it clears out the artwork when the title and artist are still the same. So I will only update the metadata when all new info is available. That works fine. :) Still needs to be solved, but at least I can work around it now. — Reply to this email directly, view it on GitHub <#2287 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZMOVVUASIQ55SYJTE5ZHP3Y3T7OTAVCNFSM6AAAAABFVUZR4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGQYTENJSGI . You are receiving this because you were mentioned.Message ID: @. com>

Will check tomorrow. I have had a busy evening, sorry. For my info: did you change something ‘under the hood’ of RNTP that might be on influence of the bug?

[Vashiru]

Having the same issue as Dennis using a local file:

const fetchMetadata = async () => {
  await fetch('https://fr2.ah.fm/stats?sid=1&json=1')
    .then(data => data.json())
    .then(async obj => {
      if (obj.songtitle && typeof obj.songtitle === 'string') {
        const currentTrack = await TrackPlayer.getActiveTrackIndex();
        if (currentTrack !== undefined) {
          TrackPlayer.updateMetadataForTrack(currentTrack, {
            title: obj.songtitle,
            artwork: require('./assets/afterhours-fm.jpg'),
          });
        }
      }
    })
    .catch(function (error) {
      console.log(error);
    });
};

This is being ran every 5 seconds through:

  useEffect(() => {
    const intervalId = setInterval(() => fetchMetadata(), 5000);

    return () => clearInterval(intervalId);
  }, []);

Initially the artwork will load, but as soon as updateMetadataForTrack gets called again, the image disappears.