Regression - 0.43.2 finds fewer files than 0.43.1

[bradzacher]

Regression - 0.43.2 finds fewer files than 0.43.1

[dsherret]

Ah, I remember that now and thanks for spotting this! I'll add a test for this scenario and look into this soon.

[dsherret]

Should be fixed now in the latest release.

[dsherret]

@bradzacher I was looking at this more and realized the CLI args just overridding what's in the config isn't a good design. I opened #804 -- Does what's done there make sense? Let me know if you have any suggestions.

[bradzacher]

That seems logical to me.

Based on what I've seen internally - all the usecases we have for CLI args is exactly as you describe - we are instructing dprint to format a subset of the allowed files and nothing more.

I don't even think people use the exclude arg - they just run dprint fmt "some/folder/**/*" to ensure their changes are good before submitting them.

Also worth noting that from CI we also don't even pass globs any more or call output-file-paths - we have got it fast enough to just run dprint fmt on CI!!

[dsherret]

Great. I'm going to merge this and do a minor release tonight. I'm pretty confident that most people would expect this behaviour.

Also worth noting that from CI we also don't even pass globs any more or call output-file-paths - we have got it fast enough to just run dprint fmt on CI!!

That's great to hear and it's the way it should be! Way less complexity.