Comments (11)
The source of this bug is jlibsedml's ModelResolver
class. As per description, SEDMLDocument.getModelString
should apply all the list of changes to the model ( including repeatedTasks compute changes) but no changes are applied.
This is because jlibsedml's computeChange
function only supports changing:
- CHANGE_ATTRIBUTE_KIND
- REMOVE_XML_KIND
- ADD_XML_KIND
- NO_NAMESPACE
- CHANGE_XML_KIND
However, as per their documentation of Change
class, there can be following categories of changes.
- SEDMLTags.CHANGE_ATTRIBUTE_KIND
- SEDMLTags.CHANGE_XML_KIND
- SEDMLTags.ADD_XML_KIND
- SEDMLTags.REMOVE_XML_KIND
- SEDMLTags.COMPUTE_CHANGE_KIND (missing in their implementation, required to comute model changes for each iteration of repeated tasks)
- SET_VALUE_KIND
@matthiaskoenig @draeger do you guys know who is working on jlibsedml who can respond to this issue?
I see Richard Adams maintains jlibsedml and he also wrote code for SBSCL in the past. Can you connect me with him?
from sbscl.
From @draeger on July 24, 2018 8:46
I don't currently have any contact to @otter606 and am not aware of the current state of jlibsedml.
from sbscl.
From @otter606 on July 24, 2018 22:3
Hi
I got the notification but have not worked on jlibsedml for years, I think
Frank Bergmann was maintaining itm, but this was some years ago.
Richard
On Tue, Jul 24, 2018 at 9:47 AM, Andreas Dräger [email protected]
wrote:
I don't currently have any contact to @otter606
https://github.com/otter606 and am not aware of the current state of
jlibsedml.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
shalinshah1993#60 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJA6nYKBDgC7AwVDNkBGRyY3l-aOJ4mQks5uJt8WgaJpZM4VbK9Z
.
from sbscl.
From @draeger on July 25, 2018 6:56
Maybe @fbergmann can give more information?
from sbscl.
From @fbergmann on July 25, 2018 7:25
I am not actively using jlibsedml. I'd be happy to propagate any code changes to the repository, or add another developer to the list. Chris Meyers was the last to commit to the project.
from sbscl.
From @draeger on July 25, 2018 12:25
@cjmyers: what is the current state of jlibsedml?
from sbscl.
From @cjmyers on July 25, 2018 16:30
Stalled. There is no one currently actively developing it. It would be great to have someone come along and champion it.
On Jul 25, 2018, at 5:25 AM, Andreas Dräger [email protected] wrote:
@cjmyers https://github.com/cjmyers: what is the current state of jlibsedml?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub shalinshah1993#60 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD96U4wRYwWzCFhBQ5ohmBNR-8ASjZks5uKGO5gaJpZM4VbK9Z.
from sbscl.
Since no one actively managing jlibsedml, I just added my own code for working with SEDMLTags.COMPUTE_CHANGE_KIND
. Currently, the code uses string processing functions to extract SBML parameter from XPath and it updates them if SetValue element specifies a range for the parameter.
After pushing shalinshah1993@b64b096
The test cases that don't work:
- osci-nested-pulse (because functional range MathML evaluation not supported by jlibsedml yet)
- repeated-stochastic-scan (same as first)
- param-scan-2D (because SBSCL doesn't support repeated task)
Two test cases that are giving unstable results:
- repeated-steady-scan-oscli
- repeated-stochastic-runs
Their outputs are as under. My guess why we get different results is because of the use of different simulation algorithm. We use Rosenbrock solver instead of what the SED-ML files ask.
from sbscl.
@cjmyers
Do you have a Github repo that i can send pull request to?
On Jul 25, 2018, at 11:30 AM, cjmyers [email protected] wrote:
Stalled. There is no one currently actively developing it. It would be great to have someone come along and champion it.
On Jul 25, 2018, at 5:25 AM, Andreas Dräger [email protected] wrote:
@cjmyers https://github.com/cjmyers: what is the current state of jlibsedml?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub shalinshah1993#60 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD96U4wRYwWzCFhBQ5ohmBNR-8ASjZks5uKGO5gaJpZM4VbK9Z.—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.
from sbscl.
From @fbergmann on July 26, 2018 18:45
so far sources are kept in sf svn ... but if you send me a patch i will apply it happily
from sbscl.
This depends on #55
from sbscl.
Related Issues (20)
- Simulation of models with reaction without reactants and products
- Add functions in ASTNodeInterpreter class for calculating node values of SBML L3V2 models HOT 1
- Add support for rateOf csymbol HOT 12
- Event triggers before the mentioned condition HOT 4
- Misinterpretation of function variables with parameters
- Add delay property to the rateOf function HOT 1
- SBML L3V2 tests failing with no identified reason yet HOT 1
- Support for FBA FROG analysis
- Simulation of SBML models with changing compartment size HOT 4
- FBA tests fail on parallel testing HOT 2
- Terminology, Power and Oppressive Language in Computer Science HOT 2
- Refactor FERN classes to use SBSCL classes HOT 1
- Update Maven dependency documentation (version 2.0) HOT 1
- Upload SBSCL to mvnrepository HOT 3
- Improve the curation level on BioSimulators HOT 1
- Update the project's website
- Support pure Java solver for constraint-based modeling
- Exchangable solvers
- download_bigg_models.sh throws ERROR 404 HOT 2
- Errors are detected when running some SBMLTestSuite case. HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sbscl.