Giter Site home page Giter Site logo

Comments (10)

dragonman225 avatar dragonman225 commented on May 22, 2024 1

I'll probably update Notablog in this weekend.

I'll need to publish a new version of nast-util-to-react, update that dependency's version number in Notablog's package.json, test it, and publish a new version of notablog.

It seems that most of tasks in the process rely on my actions, but if you want to try it earlier (and maybe see if there're bugs in your use case), in theory, you could

  1. Clone the notablog repo, install (npm install) and build (npm run build) it.
  2. Clone the nast repo, follow the instructions to set it up.
  3. Edit the version number of nast-util-to-react in notablog's package.json, replace the version number with a local path (as described in npm's documentation) to the nast-util-to-react package in the nast repo you've cloned.
  4. Run notablog/bin/cli.js

Disclaimer: I don't test these steps, instead, I just provide the concept on how to do on your own, but if you encounter any problem I will be glad to help.

from notablog.

dragonman225 avatar dragonman225 commented on May 22, 2024

For the first issue:
I forgot to update the theme's stylesheet to match the HTML generated by the latest rendering library, so the columns are broken. Now it's been updated, please use the latest notablog-starter and the columns should be normal again.

from notablog.

dragonman225 avatar dragonman225 commented on May 22, 2024

For the second issue:
Yes, the gallery is missing many things, because it is not fully supported now. 😂
For details, refer to the documentation of the rendering library.

from notablog.

vwxyzjn avatar vwxyzjn commented on May 22, 2024

Thanks for the prompt reply. Indeed the column is being brought back. However, the display is still problematic. See

image

When it is like the following in the notion.so

image

Feel free to test with my public page https://www.notion.so/043f2251b5db4aaba615a8d703455d8c?v=157e166961ff4f06acd38b02cc148fe1

from notablog.

dragonman225 avatar dragonman225 commented on May 22, 2024

For a quick fix, you may add

.Video__Content > video {
  max-width: 100%;
}

in this file.

But this time I will not update notablog-starter immediately, because this problem involves a bigger one, which is that in Notion, image, video, and embeds, all have the same logic for layout, so I've decided to come up with a general solution for this instead of patching separately.

from notablog.

vwxyzjn avatar vwxyzjn commented on May 22, 2024

I see. I can confirm that the CSS fixed the issue.

from notablog.

vwxyzjn avatar vwxyzjn commented on May 22, 2024

Thanks a lot for the fix

from notablog.

vwxyzjn avatar vwxyzjn commented on May 22, 2024

Regarding the second issue see dragonman225/nast#3

from notablog.

kevchentw avatar kevchentw commented on May 22, 2024

I noticed that dragonman225/nast#3 was merged. I wonder that when (or how) can we use it from notablog cli. Thank you.

from notablog.

dragonman225 avatar dragonman225 commented on May 22, 2024

v0.4.1 released, changes in dragonman225/nast#3 are included.
Note that you also need to update your notablog-starter to use it!

from notablog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.