[Bug]: Unlisted breaking change in v2.6.0 with virtual folders returned by extrenal hooks

[Mathieu-COSYNS]

[Bug]: Unlisted breaking change in v2.6.0 with virtual folders returned by extrenal hooks

[drakkan]

Updated release notes, thanks for noticing. See #1349

I think it should work if you return an existing virtual folder by name.

[Mathieu-COSYNS]

Hi, thank you for the quick reply. I didn't knew about #1349. I was hopping to still be able to create virtual folders on the fly when returning user configuration. It's a bit annoying but I will adapt my approach for my external auth hook.

I think it should work if you return an existing virtual folder by name.

As I was explaining above, it does work for the Web UI but not for SSH (and FTP, WebDAV) for those you need the virtual folder id. This behavior should be consistent.

Error with error creating root directory "/virtual_path" for user "test": mkdir : no such file or directory when listing the virtual folder via SSH, if a virtual folder with the same name exist

One approach could be to change the user/group create/update API virtual_folders to take only virtual folders virtual_path, quota_size, quota_files, folder_id instead of full virtual folders configuration since setting other fields will/should not have any impact.

Should we continue this in another issue or reopen this one ?

[drakkan]

I did a quick test to confirm, returning an existing folder name is enough, the id is not required.

The OpenAPI document should be updated in several places to clarify the fields required for adding/updating and the fields returned in GETs.
If you want to help us and feel comfortable with our CLA feel free to send a PR. The PR should be complete and working to be accepted, we have currently no time for reviewing and iterating or pushing back on PRs (this is often more work than doing the change ourself). Thanks for understanding and for using SFTPGo