Comments (18)
Please remove the branches with the same name as tags.. A tag can be somewhat considered a 'named branch'. If you ever need to checkout 1.0.1 simply do that: git checkout 1.0.1
. It just works.
Deleting the 1.0.2 and 1.0.3 branches will fix the Github release URLs: https://github.com/dargullin/icheck/archive/1.0.2.zip
from icheck.
To the team managing this project:
This issue causes a big problem while upgrading a Drupal website to v9.
Please fix this right away.
from icheck.
@dargullin sorry for the direct ping but this is still broken.
from icheck.
The webform patch does indeed fix the issue but it will require patching a lot of websites.
In the mean time, renaming the 1.0.2 branch could instantly fix the problem for everyone.
from icheck.
yep, same here for both Drupal 8 and Drupal 9. gonna go with @jaylenw hack, its not nice but it works. Better if you re-name the branches not to be the same as the tags.
from icheck.
Having same issue, a patch is out here for webform contrib module who is requiring this jquery/icheck library : https://www.drupal.org/project/webform/issues/3264249
from icheck.
This potentially breaks the deployment of tens of thousands of websites using the webform module for Drupal.
The root cause is that https://github.com/dargullin/icheck/archive/1.0.2.zip returns this weird error:
the given path has multiple possibilities: #<Git::Ref:0x00007f0f498260b8>, #<Git::Ref:0x00007f0f49825b68>
Edit: the problem is caused by the fact that 1.0.2
is both a tag and a branch
from icheck.
@prudloff-insite installing the patch (for webform 6.1.2 at least) will resolve the issue for now as long as you make sure the composer lock file is updated correctly. I would not be surprised if updating webform will be the solution to this problem since the webform module links to github/fronteed which in turn links to this repo.
from icheck.
This is breaking the developer workflow of anyone trying to use this package. Please remove the branches for 1.0.2
and 1.0.3
.
from icheck.
this patch for webform worked for us
https://www.drupal.org/files/issues/2022-02-14/3264249-6.2.x.patch
from icheck.
I also got bit by this today. Please fix.
from icheck.
Having the same issue.
from icheck.
Removing icheck
's entry in my project's composer.lock
file and then re-running composer install
fixed the issue for me.
from icheck.
from icheck.
Please remove the branches.
from icheck.
Same here, please remove branches
from icheck.
Same issue.
from icheck.
In the composer.lock
file I tried replacing https://github.com/fronteed/icheck/archive/1.0.2.zip
with https://github.com/dargullin/icheck/archive/refs/tags/1.0.2.zip
and it worked when running composer install
. It is not a perfect solution. Got the idea from https://www.drupal.org/project/webform/issues/3264249#comment-14422171
from icheck.
Related Issues (20)
- it can not be aligned horizontally in a td of table. HOT 1
- Not working with asp radiobuttonlist HOT 2
- iCheck disabled checked HOT 1
- Problems with ios 13 HOT 7
- Problem when going back then forward. HOT 2
- Mac Safari iCheck won't render HOT 4
- IPAD icheck- checkbox not working HOT 3
- iCheck library not compatible with JAWS screen reader for accessibility HOT 2
- checking checked state of check box gives flipped result HOT 1
- v1.0.3 not available on yarn install HOT 1
- Getting issues on touch screens with v1.0.3 HOT 1
- Custom data elements HOT 1
- iCheck is causing div collapse
- disable icheck in readonly
- iCheck in not working in Flutter - Android webviews HOT 1
- Docs website is down
- Checkbox does not work on mobile with Desktop Site mode HOT 4
- Icheck not working on mobile chrome that uses desktop site view enabled
- skins have invalid CSS that breaks the width of the iCheck
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from icheck.