Giter Site home page Giter Site logo

Comments (2)

pjbull avatar pjbull commented on June 7, 2024

Thanks for the report @Midnighter!

The changes to clean and lint seem good to me unless @isms had a thought as to why we would lint other directories. Also I'm a little wary of a rm -rf hidden in a Make command, so maybe we do both and remove the empty __pycache__ with rmdir instead.

WRT to requirements my reading of the doc is that requirements.txt is still where requirements will live by convention (including pinning certain versions). It seems that the constraints file is if you want to enforce certain versions across projects, for example, you can include one that will automate the checking that the project meets the requirements. However, it doesn't install the requirements. I'd leave as is.

from cookiecutter-data-science.

isms avatar isms commented on June 7, 2024

Thanks @Midnighter. Chiming in with some thoughts:

requirements: this is a nice point but I vote we revisit when constraints.txt is more widespread.

clean: no preference since the -delete flag is sort of rm -rfish and it shouldn't be a big deal with the pattern match.

lint concur, let's just lint src/

from cookiecutter-data-science.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.