[BUG]: Type error with postgresjs strings/dates in version 0.30

[jam-fran]

[BUG]: Type error with postgresjs strings/dates in version 0.30

[jam-fran]

Quick update - I've narrowed down the source of the issue to instances where a date is passed to the sql operator, either directly (sql`${dateHereWillBreakThings}) or in a sql.placeholder(date). Doing that worked in v 0.29.x, but not in 0.30.x.

It still works to pass a date to a filter operator (e.g. gte(sessions.timestamp, startDate)).

The workaround that worked for me for now is to convert any dates used with the sql operator to strings, like sql`${date.toISOString()}.

[gp27]

I am having the same issue on version 0.30.4 when i pass Date objects to queries. The last version on which passing a Date worked correctly was 0.29.3

[jam-fran]

@gp27 Please keep me posted if you find a solution or workaround for this. I'm surprised that more people don't appear to be experiencing this since it's such a basic use case, so I feel like I must be overlooking something obvious.

[gp27]

I tried to investigate this issue further.
I think it has been introduced with this PR #1659, which fixed an issue with the postgres driver where timestamps with mode "string" that should have been returned by queries as string values, were actually parsed into Date objects.

When the parsers for timezone related types were switched, so were the serializers:
https://github.com/Angelelz/drizzle-orm/blob/b29a5e1a837cbbb45be5e2caf3564c0493c28d08/drizzle-orm/src/postgres-js/driver.ts#L28

The replacements of those serializers is probably what is causing this issue and #2009 as well.

I am not sure it was necessary to replace the serialziers as well, since the issue was on the parsing side, but I may be wrong. Maybe @Angelelz who authored the fix might have some further info about it.

[Angelelz]

The replacement of the serializer and parsers was necessary to guarantee that the same parsing/serializer code from Drizzle will work for both postgres.js and node-PG interchangeably. Unfortunately I have very little time lately to dedicate to drizzle but if somebody puts together a quick reproduction it will make it easier to investigate/fix.

[erkstruwe]

Until this is solved, a temporary workaround is to create a custom type:

import { customType } from "drizzle-orm/pg-core"

export const customDate = customType<{
    data: string
    driverData: Date
}>({
    dataType() {
        return "date"
    },
    fromDriver(value: Date): string {
        return value.toISOString().slice(0, 10)
    },
})