Giter Site home page Giter Site logo

Comments (6)

LeGrosSancho avatar LeGrosSancho commented on June 11, 2024 1

Hmm sorry, I'm not sure to understand what you mean 😅

With my sample URL, in 1.7.3, after a clean, utm parameters are removed:
Screenshot 2023-10-09 at 18 04 29

But in 1.7.6, it's not the case anymore (same with 1.8.1):
Screenshot 2023-10-09 at 18 04 43

I'm not using any facebook or cnn.com urls, so maybe this behaviour is expected, but I don't understand why there is a difference between these versions 🤔

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on June 11, 2024 1

Hey no worries, I hope you're feeling better now.
Thanks a lot for having a look 🙏 I will let you know if I have any other issue :)

from tidy-url.

DrKain avatar DrKain commented on June 11, 2024

As of the latest version (1.8.1) and the version you mentioned (1.7.3), the sample URL you provided should work as expected both locally and on the stackblitz you linked.

image

The only instances when a URL is not modified is if it matches something in the exclude array, that might be what's happening in your case. There's only two rules using this, facebook.com and cnn.com

from tidy-url.

DrKain avatar DrKain commented on June 11, 2024

I'm not sure either, I'll have to leave this open until I can reliably reproduce the issue or at least find out what's causing this discrepancy.
Thank you for reporting

from tidy-url.

LeGrosSancho avatar LeGrosSancho commented on June 11, 2024

Sure, thanks 🙏

from tidy-url.

DrKain avatar DrKain commented on June 11, 2024

Hi @LeGrosSancho, sorry for the long wait. I've just pushed a new version that should fix this issue. Sorry for the slow update, I've been a bit unwell and have not had the time to look into this further. Please let me know if you have any other problems

from tidy-url.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.