Comments (6)
Hmm sorry, I'm not sure to understand what you mean 😅
With my sample URL, in 1.7.3
, after a clean, utm parameters are removed:
But in 1.7.6
, it's not the case anymore (same with 1.8.1
):
I'm not using any facebook
or cnn.com
urls, so maybe this behaviour is expected, but I don't understand why there is a difference between these versions 🤔
from tidy-url.
Hey no worries, I hope you're feeling better now.
Thanks a lot for having a look 🙏 I will let you know if I have any other issue :)
from tidy-url.
As of the latest version (1.8.1) and the version you mentioned (1.7.3), the sample URL you provided should work as expected both locally and on the stackblitz you linked.
The only instances when a URL is not modified is if it matches something in the exclude
array, that might be what's happening in your case. There's only two rules using this, facebook.com
and cnn.com
from tidy-url.
I'm not sure either, I'll have to leave this open until I can reliably reproduce the issue or at least find out what's causing this discrepancy.
Thank you for reporting
from tidy-url.
Sure, thanks 🙏
from tidy-url.
Hi @LeGrosSancho, sorry for the long wait. I've just pushed a new version that should fix this issue. Sorry for the slow update, I've been a bit unwell and have not had the time to look into this further. Please let me know if you have any other problems
from tidy-url.
Related Issues (20)
- Website: knowyourmeme.com
- Website: wfaa.com
- Website: cbsnews.com
- Website: jdt8.net HOT 1
- Update: reddit.com
- Update: open.spotify.com
- Website: adclick.g.doubleclick.net HOT 1
- Request: Expand decode rule HOT 1
- Request: Move handlers into their own functions HOT 8
- Request: Test runner
- Other: Thoughts on what justifies as an unwanted redirect HOT 2
- Website: patchbot.io
- Bug: InvalidCharacterError: String contains an invalid character
- Broken: google.com HOT 1
- Website: vi-control.net HOT 4
- Bug: Re-clean occurs more than once HOT 1
- Broken: stardockentertainment.info
- Website: list-manage.com
- Request: Discord bot
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tidy-url.