Comments (3)
In testing adding httpx.HTTPStatusError to the try, except in download.py: Class Downloader: function adownload_fileobj, seeems to fix the issue. Currently testing to see if there is any problems before making a pull request.
from romt.
It seems I incorrectly switched from the requests
library's RequestException
base class to the httpx
library's RequestError
class; the former is the base class for all of the exceptions in requests
, whereas the latter doesn't cover all exceptions in httpx
. It looks like I should have used httpx.HTTPError
instead of httpx.RequestError
as the catch-all type.
I'd be happy to have a pull request catching httpx.HTTPError
instead of httpx.RequestError
. Thanks for finding this problem and tracking down the solution :-)
References:
- https://docs.python-requests.org/en/master/_modules/requests/exceptions/
- https://www.python-httpx.org/exceptions/
from romt.
Thanks! the fix has been released in v0.3.1.
from romt.
Related Issues (12)
- issue serving on offline laptop HOT 4
- The romt cannot be downloaded normally. HOT 5
- GIT_HTTP_BACKEND_SOURCES should be overwritable HOT 3
- Crate unpack error moving from Mac to Windows 10 HOT 5
- Case sensitive filesystems don't work? HOT 8
- What means ConnectTimeout('') and ReadTimeout('') ? HOT 3
- toolchain - nightly and stable mix/share targets HOT 2
- Spurious network error; couldn't resolve host: crates.io HOT 9
- Offline mirroring of a subset of crates.io HOT 1
- faield to download rustup in WSL HOT 2
- HTTP requests take a long time to process HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from romt.