Giter Site home page Giter Site logo

Comments (5)

CherryRum avatar CherryRum commented on June 19, 2024 1

是的 其实这个功能很久了,开始时候重叠的定义,是加上了meeting,这个注释中是明确我写了,而且提示用户精确的看艾伦区间划分,用户没有多少知道艾伦区间代数的,所以我一直也不想实现一版本新的完全符合定义的(太懒了),不过现在6.0我已经准备提交了新的艾伦区间的工具类,那个可能更加灵活以及精准。

from hutool.

looly avatar looly commented on June 19, 2024

相关PR和issue你也看了,本质上这算是个bug的存在,因此做了修复。

@CherryRum 帮忙解释下呗~~

from hutool.

looly avatar looly commented on June 19, 2024

关于不向下逻辑兼容的问题,我认为:

  1. 既然是bug,但是为了兼容而一直保留这个bug并不是一种理想状态
  2. 升级解决bug难免会有逻辑变更,我觉得这里的逻辑变更不足以导致大的升级故障,故做了修改。

from hutool.

creekmoon avatar creekmoon commented on June 19, 2024

关于不向下逻辑兼容的问题,我认为:

  1. 既然是bug,但是为了兼容而一直保留这个bug并不是一种理想状态
  2. 升级解决bug难免会有逻辑变更,我觉得这里的逻辑变更不足以导致大的升级故障,故做了修改。

感谢您的回复! 也谢谢您对我提出的问题进行思考, 我会尊重社区的选择.

实际上我赞同 #3215 的描述, 即旧版本(version<=5.8.9)连续的时间是"不重叠"的, 此特性是正确的并不是bug..
相反,是 #2725 的提交重新改写了方法的定义(与之前"重叠"的定义不同了)

from hutool.

creekmoon avatar creekmoon commented on June 19, 2024

是的 其实这个功能很久了,开始时候重叠的定义,是加上了meeting,这个注释中是明确我写了,而且提示用户精确的看艾伦区间划分,用户没有多少知道艾伦区间代数的,所以我一直也不想实现一版本新的完全符合定义的(太懒了),不过现在6.0我已经准备提交了新的艾伦区间的工具类,那个可能更加灵活以及精准。

方法名 isOverlap 是一种比较泛的概念, 确实不好定义清楚,.
对此我表示理解.
最后谢谢解答. 在此对您做出的贡献表达感谢!

from hutool.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.