Behavioral difference between google/brotli and dropbox/rust-brotli

[dropbox]

Behavioral difference between google/brotli and dropbox/rust-brotli

[alex]

diff --git a/src/ffi/compressor.rs b/src/ffi/compressor.rs
index 3dc88d3..df6b045 100755
--- a/src/ffi/compressor.rs
+++ b/src/ffi/compressor.rs
@@ -282,7 +282,11 @@ pub unsafe extern fn BrotliEncoderCompressStream(
     };
     {
       let input_buf = slice_from_raw_parts_or_nil(*input_buf_ptr, *available_in);
-      let output_buf = slice_from_raw_parts_or_nil_mut(*output_buf_ptr, *available_out);
+      let output_buf = if *available_out != 0 {
+        slice_from_raw_parts_or_nil_mut(*output_buf_ptr, *available_out)
+      } else {
+        &mut []
+      };
       let mut to = Some(0usize);
       result = ::enc::encode::BrotliEncoderCompressStream(
         &mut (*state_ptr).compressor,

should fix the segfault, however I don't know if it fixes the actual issue or just causes a problem somewhere else.

[danielrh]

your fix is good! Thanks. I didn't expect people to pass in a pointer with 0 size available plus a nullptr to the encoder library