Calculation of image size

[drtyhlpr]

Calculation of image size

[drtyhlpr]

hi, the image size calc is a bit messy - and I tought about a small "readable" replace. I tought (but it has been I while since I tested it) - that the image should be "rounded" to 1GB - but the problem with an "edge case" - like 960MB exists. give me some time to test ... I am very bussy these days ... and may take a look this weekend.

[drtyhlpr]

yeah if you would like to contribute I would be very happy. If I remember right - my idea was to simply add a "min space left free" VARIABLE and simple add this to the calculated "used space" value before the "round" to 1GB

[stylesuxx]

Hey @drtyhlpr I started playing around with this yesterday. Problem is, that with EXT4 it is very hard to get the exact partition size, because of reserved blocks and journaling. So I came up with the following: https://github.com/stylesuxx/rpi2-gen-image/commit/d20b2e032c39241719850e6a96ef28b60419534c I simply add 20% of the chroot size. This should be easily adaptable to a variable with fixed sized instead of percentage. Let me know what you think and I will prepare a PR.

[drtyhlpr]

I like the patch a lot (math calc on sh is some how a pain in the...) (my alternative idea would be a BC script but this would add another host build dep) but lets simply keep it in sh with you percentage patch and it would be nice if you could create a PR. I want to merge the other(s) PRs soon and do some massive "build testing" (like building images will many different kind of ARGS) - so I can simply 'df' cross check and QS all additional patches and features of the PRs.

[stylesuxx]

Alright, I'll prepare a PR then. Also my dev branch has fixes for #20 and #21 do you want them too, or should I make seperate PR's for each?

[drtyhlpr]

please seperate them I am not a merge master and need to learn more about git :)

[stylesuxx]

Alright, will do that some time over the weekend - my RPi 3 just arrived, and I am a bit distracted ;-)

[drtyhlpr]

have fun - maybe you wanna try https://github.com/umiddelb/z2d/tree/master/pine64 :)

[drtyhlpr]

great job / merged / maybe add 25% but auto resize on firstboot should work fine.