Page jumps to top

[drublic]

Page jumps to top

[staabm]

just add a "return false" onclick handler and you are fine.

[kahlil]

Or use a button tag instead of a link?

[Schepp]

I think it's the doctype! ;D

Jokes aside, the reason is that the body is being set to overflow: hidden, and I think @drublic is well aware of it and will find a good fix.

[kahlil]

Yes, I am very confident in @drublic's ability to find a fix as well. 👍 😄

[ryanseddon]

You may want to checkout @benschwarz http://benschwarz.github.io/gallery-css/ project where he uses a super cool trick to stop the jump happening by using hidden divs with the ids that then use general sibling combinator (~) to target the right item.

[benschwarz]

Thanks @ryanseddon, I was actually going to PR something when I saw this project, but I hadn't had the chance yet.

[drublic]

Thanks, Ryan! I'll check it out.
@benschwarz PR is always very welcome :)

[drublic]

If I invested correctly, this means we need extra markup to target each hidden div. I use this method a lot for navigations, especially on mobile where you need a toggle button for the menu to be visible or not. It is also a method that I use in a modified version for the tabbed content on the page.
To be honest I don't think this will work perfectly with the modals since the jumping bug originates in preventing the overflow for the content an thus prevent scrolling the content.
I will try out some more and come up with a solution shortly.

[drublic]

And here is the solution. Pretty easy. Please let me know if you find any bugs in this fix.
I've also added a test to prevent regression.

[kahlil]

Sweet. Works great now.

Am 10.05.2013 um 23:10 schrieb Hans Christian Reinl [email protected]:

And here is the solution. Pretty easy. Please let me know if you find any bugs in this fix.
I've also added a test to prevent regression.

—
Reply to this email directly or view it on GitHub.