Giter Site home page Giter Site logo

Comments (7)

anselmh avatar anselmh commented on May 27, 2024

Nope, this no bug, there is no interactivity on the example yet. I'm closing this for now but you're kindly invited to fork, edit and send a pull-request to add the feature you expected to see here.

from css-modal.

drublic avatar drublic commented on May 27, 2024

Would you guys think it makes sense to add a kind of gallery for this modal? I mean for the page only.
Should be easy to do.

from css-modal.

anselmh avatar anselmh commented on May 27, 2024

Sorry for closing, @drublic. I do think it would make sense, yes.

from css-modal.

drublic avatar drublic commented on May 27, 2024

No worries man :) We could do this with some lines of JS but we would need all images in the proper size. I'll look into it :)

from css-modal.

matt-bailey avatar matt-bailey commented on May 27, 2024

My thoughts are that at the moment it looks like a gallery, but doesn't behave like one (hence my original question). It's not a problem at all if you don't want to add any gallery functionality (after all, it's not what your module is about), but I would suggest maybe just laying out the images in a grid, rather than one main image and some thumbnails. Does that make sense do you think?

from css-modal.

drublic avatar drublic commented on May 27, 2024

@matt-bailey Makes a lot of sense. Actually we had this issue before (on Twitter I think). Anyway I think gallery functionality is pretty easy doable. So I'm implementing this tonight :D

from css-modal.

drublic avatar drublic commented on May 27, 2024

Nothing awesome, but it has a functionality now \o/ Micro gallery, hehe.
Thanks again for the discussion, people.

from css-modal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.