Comments (7)
Nope, this no bug, there is no interactivity on the example yet. I'm closing this for now but you're kindly invited to fork, edit and send a pull-request to add the feature you expected to see here.
from css-modal.
Would you guys think it makes sense to add a kind of gallery for this modal? I mean for the page only.
Should be easy to do.
from css-modal.
Sorry for closing, @drublic. I do think it would make sense, yes.
from css-modal.
No worries man :) We could do this with some lines of JS but we would need all images in the proper size. I'll look into it :)
from css-modal.
My thoughts are that at the moment it looks like a gallery, but doesn't behave like one (hence my original question). It's not a problem at all if you don't want to add any gallery functionality (after all, it's not what your module is about), but I would suggest maybe just laying out the images in a grid, rather than one main image and some thumbnails. Does that make sense do you think?
from css-modal.
@matt-bailey Makes a lot of sense. Actually we had this issue before (on Twitter I think). Anyway I think gallery functionality is pretty easy doable. So I'm implementing this tonight :D
from css-modal.
Nothing awesome, but it has a functionality now \o/ Micro gallery, hehe.
Thanks again for the discussion, people.
from css-modal.
Related Issues (20)
- Strange scrolling bug HOT 2
- Drop IE8 and Android 2 with next version HOT 1
- data-iframe-src HOT 1
- Scrolling issue on Android 5.0 HOT 3
- Namespace data-attributes
- Incorrect function calls - modal.js HOT 1
- <iframe> breaks the js HOT 2
- Question: modal height when using more than one div and JS
- AMD pattern nested inside
- Closing stackable modals
- ".modal-content" spacing inconsistencies
- Release latest version on npm HOT 1
- modal w/form & input fields shifts out of view when keyboard opens [iPhone-only] HOT 2
- Event handlers not registering properly
- Unnecessary scrollbar HOT 2
- Download v1.4.0 HOT 4
- html overflow property HOT 1
- video keeps playing after close HOT 5
- cssmodal:show / cssmodal:hide dialog reference in event HOT 2
- css bug! HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from css-modal.