Lightbox Sizing

[drublic]

Lightbox Sizing

[anselmh]

Hey,

regarding 1: Yes, definitely wanted but I do think we will need to shift this into 1.2.0 as this needs some more re-structuring in the code and 1.1 should be served as soon as possible now.
regarding 2: Do you have a proposal how to handle this? It could be done with an data-attribute but I'm not sure if we want to do that as it shifts layout properties into html markup. But maybe you have a better solution how to handle that?

Thanks for your feedback! :)
-Anselm

[grayghostvisuals]

@anselmh
Not sure on a solution ATM, but handling multiple sizes should be a priority high on the list. I do like the idea of data attributes just unsure how that correlates with the rest of the library. I haven't had time to dig deeper into the project code :( Gotstah be solution out there for sure. 🍻

[anselmh]

Well, be sure we will keep care of this (in my personal opinion right after 1.1 shipped). But I want to let the decision about the handling of this up to @drublic so let's wait what he says about this feature-request.

[drublic]

@anselmh Is this related to what happens in branch plugins?

[anselmh]

Hm… not directly. This issue is more about more manageable breakpoints but at least branch plugin-resize will tackle a bit of the problem.

[drublic]

@grayghostvisuals Please have a look at #133 for 2). This might also be a solution for 1).

[grayghostvisuals]

if you all like it then I'm all 👍 for it.

[drublic]

A css only variant would be nice too. But you can do this by overwriting
some values.

This implementation is a variant for when you want to set a width which
comes from a CMS or another user input.

On Tue, May 27, 2014 at 7:45 PM, Dennis Gaebel [email protected]:

if you all like it then I'm all [image: 👍] for it.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-44309585
.

[drublic]

Closing this as we've implemented one solution. Please feel free to open a new issue if you are not happy with the current result.