Giter Site home page Giter Site logo

Comments (6)

tsvx avatar tsvx commented on June 24, 2024

It has turned out that this approach is incomplete. We should dispose the logger, it turns out this is given in the documentation.

from aspnet-core-rest-service.

drwatson1 avatar drwatson1 commented on June 24, 2024

You are right, thank you for pointing it out. I've decided to improve logging in the template based on the latest versions of Serilog extensions and documentation.

from aspnet-core-rest-service.

drwatson1 avatar drwatson1 commented on June 24, 2024

I've updated the template just now - https://marketplace.visualstudio.com/items?itemName=sergey-tregub.asp-net-core-restful-service-template.

Is the solution suitable for you?
Is there something else that I can improve?

from aspnet-core-rest-service.

tsvx avatar tsvx commented on June 24, 2024

Thank you, Sergey. Looks like what I wanted. I am definitely going to test this solution when I start a new ASP.NET Core project.

One note on the cafec9d commit, it seems that the ConfigureLogging(..) call is redundant after adding UseSerilog(..). Also, that call replaces Log.Logger which is supposed to be modified (or replaced) in the UseSerilog(..) call. Please correct me if I am wrong.

from aspnet-core-rest-service.

drwatson1 avatar drwatson1 commented on June 24, 2024

You are right as always :) I forgot to remove ConfigureLogging after UseSerilog was added.

from aspnet-core-rest-service.

drwatson1 avatar drwatson1 commented on June 24, 2024

I close the issue now. Feel free to open a new issue if you find any other problems. Thank you for your contribution.

from aspnet-core-rest-service.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.