Comments (8)
We already have features that are not available in plain Hash API and I don't think it was ever a requirement that Container must be replaceable by a plain Hash.
from dry-container.
This feature seems like the kind of generic functionality that would fit just fine in dry-container.
After all, dry-container already supports the idea of "namespaces" when it comes to registering entries, and we can already hack together a namespaced iteration like @paul demonstrates, so I think it'd be good to have in place here.
from dry-container.
hey, I think it's a good idea and this functionality can be useful in other projects/gems. But I'm not sure that should we really add it to dry-container. @solnic @timriley WDYT folks?
from dry-container.
But I'm not sure that should we really add it to dry-container.
@davydovanton why?
from dry-container.
@solnic I think it can be useful in business logic more (just IMHO) and I'm not sure that it's a good idea to make dry-container more complex. Also, I see one good example of usage of this functionality in hanami (like use internal container Container['hanami.core']
or something like this, but in hanami we use dry-system). That's why I think it will be a good idea to implement it in dry-system's container. But it will be ok for me to implement it in dry-container too. I just want to say that I see it as a dry-system feature more.
from dry-container.
I agree, this should be implemented here.
from dry-container.
The potential problem is if some API depends on this feature you won't be able to swap the container with a plain hash or something else.
from dry-container.
True, but I think that's something we can live with.
from dry-container.
Related Issues (20)
- Travis build fails on rbx-2
- Including mixin into a class with initializer doesn't work HOT 1
- Allow overwriting of component keys in container HOT 3
- Custom resolver using lambda seems not to conform to the resolver interface. HOT 7
- What do think about introduction of interceptors for instantiated services? HOT 12
- set default memoization for container HOT 1
- Proposal: Meta information for container objects HOT 5
- Stubbing non-existant container values HOT 1
- Simple resolver customization causing errors HOT 1
- Freeze a Container?
- Reseting registry when testing HOT 1
- Container#dup should dup the underlying _container
- Test failures HOT 1
- Problems with ActiveSupport tagged logging HOT 2
- Fix incorrect version listed in docs HOT 10
- Cannot install 0.8.0 in JRuby HOT 14
- Getting an `ArgumentError` missing keywords on Ruby 3 HOT 2
- Getting an `ArgumentError` missing keywords on Ruby 2.7.3 HOT 5
- After updating to rails 7 , getting this error HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dry-container.