Giter Site home page Giter Site logo

Quotes about jetzt HOT 4 OPEN

ds300 avatar ds300 commented on June 12, 2024
Quotes

from jetzt.

Comments (4)

ecsplendid avatar ecsplendid commented on June 12, 2024

Can you test my version and see if that's any better -- https://github.com/ecsplendid/jetzt

Try pressing alt-a on that article

from jetzt.

ds300 avatar ds300 commented on June 12, 2024

This is a problem with the current DOM parsing function; if I select the text manually (and therefore bypass the DOM parser) there are no nested quotes.

Have no fear, @MB6. A brand new wonderful DOM parsing function is being written as we speak! :)

from jetzt.

MB6 avatar MB6 commented on June 12, 2024

@ecsplendid, some feedback (I don't mean any of this in a mean way, I like it very much)

  1. alt - a does nothing for me, that may be because I'm on a mac and have to go control - option - a to get alt - a
  2. I haven't seen any nested quotes in your version. I think you've fixed it! :)
  3. buuut, your single quotes are broken,
    the text reads: "from everything we've seen ,..."
    and I get:
    screen shot 2014-03-12 at 3 59 25 pm

The text reads: 'wards' around the
and I get:
screen shot 2014-03-12 at 4 03 01 pm

  1. Is something with your pivots different from the original?
  2. I'm not sure I like the font (but its growing on me!)
  3. The punctuation highlighting is growing on me too
    all over, good work

@ds300
I am awaiting the new fancy DOM parser!

from jetzt.

ecsplendid avatar ecsplendid commented on June 12, 2024

Ahh we've I didn't have a regex rule for that. I've updated for that

The current pattern is

/['’](?=(([dst]|nt|es|re|ve)[\s$\n])|cause|em|cept|tis|\d{2})/gi
/s['’](?=\s|\n)/gi

Which basically means any quotes that are followed by a d,s,t, "nt", "es", "re", "ve" then a space or followed by cause,em, cept or tis or two digits are not a part of a quotation.

I think I might give up on the single quote parsing though, it's a nightmare and will not work in all situations without some "moon-shot" investment of time!

I really appreciate you taking a look though, I hope I have explored some concepts. I feel drained now and will just wait to see what @ds300 comes up with next and reconcile with that.

"Is something with your pivots different from the original?"

Yes when I call the get pivot function, I strip out any punctuation or anything that isn't a letter basically, so ".", "-", ";" etc will come out. This may slightly shift the balance to the left!

from jetzt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.