Comments (4)
Can you test my version and see if that's any better -- https://github.com/ecsplendid/jetzt
Try pressing alt-a on that article
from jetzt.
This is a problem with the current DOM parsing function; if I select the text manually (and therefore bypass the DOM parser) there are no nested quotes.
Have no fear, @MB6. A brand new wonderful DOM parsing function is being written as we speak! :)
from jetzt.
@ecsplendid, some feedback (I don't mean any of this in a mean way, I like it very much)
- alt - a does nothing for me, that may be because I'm on a mac and have to go control - option - a to get alt - a
- I haven't seen any nested quotes in your version. I think you've fixed it! :)
- buuut, your single quotes are broken,
the text reads: "from everything we've seen ,..."
and I get:
The text reads: 'wards' around the
and I get:
- Is something with your pivots different from the original?
- I'm not sure I like the font (but its growing on me!)
- The punctuation highlighting is growing on me too
all over, good work
@ds300
I am awaiting the new fancy DOM parser!
from jetzt.
Ahh we've I didn't have a regex rule for that. I've updated for that
The current pattern is
/['’](?=(([dst]|nt|es|re|ve)[\s$\n])|cause|em|cept|tis|\d{2})/gi
/s['’](?=\s|\n)/gi
Which basically means any quotes that are followed by a d,s,t, "nt", "es", "re", "ve" then a space or followed by cause,em, cept or tis or two digits are not a part of a quotation.
I think I might give up on the single quote parsing though, it's a nightmare and will not work in all situations without some "moon-shot" investment of time!
I really appreciate you taking a look though, I hope I have explored some concepts. I feel drained now and will just wait to see what @ds300 comes up with next and reconcile with that.
"Is something with your pivots different from the original?"
Yes when I call the get pivot function, I strip out any punctuation or anything that isn't a letter basically, so ".", "-", ";" etc will come out. This may slightly shift the balance to the left!
from jetzt.
Related Issues (20)
- Using latest code in bookmarklet HOT 6
- Scroll page while reading HOT 1
- Document where the main algorithm is implemented and how it works HOT 1
- how to install in my hard drive and modify the bookmarklet to keep my wpm values HOT 4
- Safari CSS and key binding errors HOT 6
- CSS in ds300.github.io is outdated HOT 1
- Strange dash behavior HOT 8
- Use hyphenization algorithm. HOT 5
- Mandarin/other languages feature? HOT 1
- Larger word area - feature request HOT 2
- Sin of David Sheldrick aka ds300 HOT 17
- Not working on Facebook. HOT 1
- Memory bug when trying to read a long text
- Firefox extension HOT 23
- Strip <code> & <img> tags HOT 2
- Suggestion: remove keyboard shortcut HOT 3
- Reanimate the project? HOT 2
- Feature: Set the Default Speed
- Breaks when using dark reader extension HOT 1
- Flip horizontally
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jetzt.