KeyValuePair errors during Test-TargetResource if file doesn't exist

[dsccommunity]

KeyValuePair errors during Test-TargetResource if file doesn't exist

[PlagueHO]

Great point @jcwalker - I totally agree - this should behave like this. I'll try and put some time in this weekend.

[jcwalker]

@PlagueHO Awesome! If you need any help feel free to reach out.

[jcwalker]

@PlagueHO I started this today. Looking at the code there is a Assert-ParametersValid function that only tests for a file's existence and then returns an error. Since we agreed that we should return $false instead are you cool with removing the function all together and have a separate test if the file exists?

[PlagueHO]

@jcwalker - yep - that sounds good. Less code is usually best 😁

[jcwalker]

@PlagueHO After my last comment I changed the Assert-ParametersValid to check for the parent path of the file being managed. That way it has the same functionality as before, at least the same idea :)

Here is where I'm at currently. I have the KeyValuePiarFile resource updated just need to do the same to the other 3 resources. If you see any problems let me know.

[PlagueHO]

I've just got one issue (PowerShell/DscResource.Tests#256) to fix over in DSCResource.Tests for the DSC resource kit before I release this to PS Gallery. But I'm hoping to fix that today. Thanks again for this contribution!