Comments (9)
Hi @jnury - sure! I would gratefully accept the PR! I have adopted the standard contribution policies and style guidelines of the DSC Resource Kit.
from filecontentdsc.
I want to bring this back from the dead @jnury @PlagueHO .
What do you think about adding an Encoding parameter to all the resources? It's should be a quick win being that Set-Content has an Encoding parameter.
from filecontentdsc.
HI @jcwalker - I'd be grateful for the assist - I've not had much time of late to get DSC stuff done.
Regarding the expected behavior: If the Encoding parameter was specified, but it differed from the Encoding on the existing file, would you expect that the file encoding was corrected on the file?
I think as a consumer of the resource that a file would be converted to the correct format.
from filecontentdsc.
I agree. I would think if the desired encoding was different than the original file it would be converted.
from filecontentdsc.
Are we agreeing that we should move forward with using the Encoding parameter instead of creating a new resource? I would be happy to own this and could start early next week.
from filecontentdsc.
@jcwalker - absolutely agree! And I'd love the help if you're up for submitting a PR. I haven't had as much time to put into these projects lately (hands full on the DSC Resource kit).
from filecontentdsc.
@PlagueHO cool!, I plan to submit a PR for this issue and issue #13 within the next two weeks
from filecontentdsc.
@PlagueHO I discussed this issue with @jcwalker and I'll be picking this up for him.
from filecontentdsc.
Awesome - thanks @nehrua
from filecontentdsc.
Related Issues (20)
- Complete Transfer of Ownership
- Update module to new CI and release process HOT 1
- Correct Pipeline Include Path in Azure Pipeline Build YAML
- Update to Use Latest Version of ModuleBuilder and merge HISTORIC_CHANGELOG
- Convert Module to use DSCResource.Common
- Correct Build.YML to Support ModuleBuilder 1.7.0
- Fix Build Failures due to Pester 5.x
- Enable Automated Documentation Publish to Wiki in Deployment
- Rename master branch to main
- Add ability to specify whether UTF8 files have a BOM or not
- Update GitVersion.yml to use latest pattern
- Update Sampler Build Tasks
- Enable Code Coverage Reporting
- Update Azure DevOps Pipeline Images
- Update CI Pipeline Files from Latest Pattern
- Convert to class-based resources
- Convert tests to Pester 5
- Unable to use Powershell code containing the $ sign as value for the Text key of the KeyValuePairFile resource HOT 1
- KeyValuePairFile: Key Value Pair not removed when 'Ensure' marked as 'Absent'
- Please add support for JSON files
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from filecontentdsc.