Giter Site home page Giter Site logo

Comments (9)

PlagueHO avatar PlagueHO commented on June 12, 2024

Hi @jnury - sure! I would gratefully accept the PR! I have adopted the standard contribution policies and style guidelines of the DSC Resource Kit.

from filecontentdsc.

jcwalker avatar jcwalker commented on June 12, 2024

I want to bring this back from the dead @jnury @PlagueHO .
What do you think about adding an Encoding parameter to all the resources? It's should be a quick win being that Set-Content has an Encoding parameter.

from filecontentdsc.

PlagueHO avatar PlagueHO commented on June 12, 2024

HI @jcwalker - I'd be grateful for the assist - I've not had much time of late to get DSC stuff done.

Regarding the expected behavior: If the Encoding parameter was specified, but it differed from the Encoding on the existing file, would you expect that the file encoding was corrected on the file?

I think as a consumer of the resource that a file would be converted to the correct format.

from filecontentdsc.

jcwalker avatar jcwalker commented on June 12, 2024

I agree. I would think if the desired encoding was different than the original file it would be converted.

from filecontentdsc.

jcwalker avatar jcwalker commented on June 12, 2024

Are we agreeing that we should move forward with using the Encoding parameter instead of creating a new resource? I would be happy to own this and could start early next week.

from filecontentdsc.

PlagueHO avatar PlagueHO commented on June 12, 2024

@jcwalker - absolutely agree! And I'd love the help if you're up for submitting a PR. I haven't had as much time to put into these projects lately (hands full on the DSC Resource kit).

from filecontentdsc.

jcwalker avatar jcwalker commented on June 12, 2024

@PlagueHO cool!, I plan to submit a PR for this issue and issue #13 within the next two weeks

from filecontentdsc.

nehrua avatar nehrua commented on June 12, 2024

@PlagueHO I discussed this issue with @jcwalker and I'll be picking this up for him.

from filecontentdsc.

PlagueHO avatar PlagueHO commented on June 12, 2024

Awesome - thanks @nehrua

from filecontentdsc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.