Giter Site home page Giter Site logo

Comments (6)

iainbrighton avatar iainbrighton commented on July 24, 2024

I agree that the gateway resource should be in a separate resource. There may be times you don't want to set a gateway (on a second NIC for example) but the IPAddress resource currently requires this!

from networkingdsc.

PlagueHO avatar PlagueHO commented on July 24, 2024

👍
This change does make sense to me and would simplify a lot of my configs.

Presumably the schema would be something like this?

[ClassVersion("1.0.0"), FriendlyName("xGatewayAddress")] 
class MSFT_xGatewayAddress : OMI_BaseResource
{
  [Write] string Address;
  [Write, Description("Ensure the presence/absence of the resource"), ValueMap{"Present", "Absent"},Values{"Present", "Absent"}] String Ensure;
  [Key] string InterfaceAlias;
  [Key,Write,ValueMap{"IPv4", "IPv6"},Values{"IPv4", "IPv6"}] string AddressFamily;
};

I set both IPv4 and IPv6 gateways on the same interface usually so ideally it would support both :)

from networkingdsc.

tysonjhayes avatar tysonjhayes commented on July 24, 2024

Yeah that seems pretty good to me. I won't have time for a bit to get started on it but if if anyone wants to take a pass I'd gladly do a code review.

from networkingdsc.

PlagueHO avatar PlagueHO commented on July 24, 2024

I'm happy to take it on if it's good with you. After all, it'll simplify my configs :)

from networkingdsc.

tysonjhayes avatar tysonjhayes commented on July 24, 2024

Consider it yours @PlagueHO. I would ask that part of your commit be to remove it from xIPAddress to satisfy #22. Otherwise your config looks good!

from networkingdsc.

tysonjhayes avatar tysonjhayes commented on July 24, 2024

This is fixed, closing this out. Thanks everyone!

from networkingdsc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.