SqlWindowsFirewall: Duplicate Browser Firewall Rule for AS feature creates Error in subsequent Test-TargetResource runs

[jerfried]

SqlWindowsFirewall: Duplicate Browser Firewall Rule for AS feature creates Error in subsequent Test-TargetResource runs

[johlju]

I suggest to set $getTargetResourceResult.BrowserFirewall to $true after these two lines:

SqlServerDsc/source/DSCResources/DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1

Line 477 in f9bde8a

New-NetFirewallRule @browserFirewallRuleParameters

SqlServerDsc/source/DSCResources/DSC_SqlWindowsFirewall/DSC_SqlWindowsFirewall.psm1

Line 546 in f9bde8a

New-NetFirewallRule @browserFirewallRuleParameters

That will make sure it won't try to add it twice on the first run.

[johlju]

Happy to review a PR that fixes this.

[jerfried]

Hi and thanks a lot for your immediate action on this issue and of course for maintaining this great project! Since I am new to this process it took me a moment to get familiar with it, I hope I managed to adhere to the guidelines. Feel free to correct me where I failed to do so.
I very much agree with your suggestion, it is more transparent that way. I forked the project and will submit a PR shortly.