SqlSetup: Seems to evaluate the `SourcePath` too early for Puppet

[unkinected]

SqlSetup: Seems to evaluate the `SourcePath` too early for Puppet

[johlju]

If "loading facts" stage runs the method Get on all DSC resources then the media must be available at that point since the version of the media (the version of setup.exe) is used to determine the version that is gonna be installed (media must be available for all methods, Get, Test, and Set).

[johlju]

Is it possible to tell Puppet not to evaluate SqlSetup until runtime?

[johlju]

my first step is to copy the iso from a corporate file share and extract it

Another option is let SqlSetup do this copy by adding SourceCredential. Then it will mount a share that SourcePath points at and get the version from sqlsetup.exe on that path (it must be already extracted at source). When method Set run it will mount the share and copy the content of the SourcePath to a temporary local path, and install from that local path.

[unkinected]

Is it possible to tell Puppet not to evaluate SqlSetup until runtime?

I thought I had done all that by trying dependencies, virtual resources, and run stages, but if there's a way to delay Puppet calling Get-TargetResource until later, I'm not sure.

I took a look at the source code for sqlsetup and tried playing around by adding an optional "SqlVersion" parameter that would obviate the need for SourcePath during Get-TargetResource. I got too far in the weeds and decided to go another route.

It looks like the SourceCredential option wouldn't work for me... the "corporate file share" I mentioned is actually in an Azure storage file share, which is not as easily accessible, so the steps to download the ISO and extract it require more work than sqlsetup can handle.

I've worked around this for now by simply requiring our team to download and extract the ISO before applying the sqlsetup module. This two step process is less than ideal, but at least it gets me to the end goal.

[johlju]

I took a look at the source code for sqlsetup and tried playing around by adding an optional "SqlVersion" parameter

That was a thought I had too when I read this issue. I think it would be easy enough to just set $sqlVersion to a parameter SqlVersion instead of running these two lines.

SqlServerDsc/source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1

Line 195 in 527dcd4

$sqlVersion = Get-FilePathMajorVersion -Path $pathToSetupExecutable

SqlServerDsc/source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1

Line 1015 in 527dcd4

$sqlVersion = Get-FilePathMajorVersion -Path $pathToSetupExecutable

Since it would be optional it wouldn't break anything else.

[johlju]

@unkinected I pushed this change in 16.5.0-preview0001 - try it and report back if there are any issues.