[v2 beta] After dying while downloading, the world metadata will not be saved

[nairol]

[v2 beta] After dying while downloading, the world metadata will not be saved

[dslake]

I added the player to a static field but it doesn't fix the problem because there is no hook for when the player dies or gets disconnected in the beta v2 version. I'l looking where to add that and then I'll push the fix.

[nairol]

Hmm, strange that it doesn't work. I had it like that in an older version and removed it again because I couldn't remember why I added it in the first place. :)
I don't know why you'd need to know when the player dies. The important thing to have is a reference to the last active player (dead or not) when the metadata and player data is saved.
I might be missing something though. I don't have the code here at the moment.

[nairol]

By the way, should I fix bugs in master, in new branches or in a branch in a fork?

EDIT: I meant "wdl2" when I wrote "master".

[dslake]

In the dslake repo, there is a master branch and a wdl2 branch. On master,
I have your older code, updated for 1.3.2. On wdl2, I have your latest code
updated for 1.3.2 with some of the bugs I've fixed and stuff like ender
chests. If you want to work on the latest stuff, it's in wdl2. I'm not
really planning to continue working on the master branch and eventually
once I get the seed saving and this dying bug fixed, I'll probably merge
wdl2 into master. Then, there will not be a beta version anymore, just
World Downloader latest. Thanks for taking a look at these. I was at PAX in
Seattle, Washington all weekend so I didn't get a chance to make progress
on these. I'll have more time this week and if you check in a fix, I'll
compile and update the beta download files. Thanks!

On Tue, Sep 4, 2012 at 1:29 PM, Florian [email protected] wrote:

By the way, should I fix bugs in master, in new branches or in a branch in
a fork?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-8277618.

danthedad

[nairol]

I missed a few mc.thePlayers in other files...